Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41971: Fix test failure in test.test_tools.test_c_analyzer when mutating global state #22652

Merged
merged 1 commit into from Oct 11, 2020
Merged

bpo-41971: Fix test failure in test.test_tools.test_c_analyzer when mutating global state #22652

merged 1 commit into from Oct 11, 2020

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Oct 11, 2020 •
edited by bedevere-bot

@pablogsal
Copy link
Author

@pablogsal pablogsal commented Oct 11, 2020 •
edited by bedevere-bot 

~/github/python/master [bpo-41971](https://bugs.python.org/issue41971)*
❯ cat matchfile
test.test_tools.*
test.test_imp.ImportTests.test_load_from_source

~/github/python/master [bpo-41971](https://bugs.python.org/issue41971)*
❯ ./python -m test --matchfile matchfile test_check_c_globals test_imp test_tools -m test_typical
0:00:00 load avg: 1.00 Run tests sequentially
0:00:00 load avg: 1.00 [1/3] test_check_c_globals
0:00:00 load avg: 1.00 [2/3] test_imp -- test_check_c_globals run no tests
0:00:00 load avg: 1.00 [3/3] test_tools

== Tests result: SUCCESS ==

All 2 tests OK.

1 test run no tests:
    test_check_c_globals

Total duration: 3.3 sec
Tests result: SUCCESS

@pablogsal pablogsal merged commit 47ecfd8 into python:master Oct 11, 2020
9 checks passed
@miss-islington
Copy link

@miss-islington miss-islington commented Oct 11, 2020

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@pablogsal pablogsal deleted the bpo-41971 branch Oct 11, 2020
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Oct 11, 2020

GH-22653 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 11, 2020
@pablogsal @miss-islington
bpo-41971: Fix test failure in test.test_tools.test_c_analyzer when m…
c9f4267 
…utating global state (pythonGH-22652)

(cherry picked from commit 47ecfd8)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this issue Oct 11, 2020
@miss-islington @pablogsal
bpo-41971: Fix test failure in test.test_tools.test_c_analyzer when m…
4af6729 
…utating global state (GH-22652) (GH-22653)

(cherry picked from commit 47ecfd8)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
xzy3 pushed a commit to xzy3/cpython that referenced this issue Oct 18, 2020
@pablogsal
bpo-41971: Fix test failure in test.test_tools.test_c_analyzer when m…
14358bf 
…utating global state (pythonGH-22652)
adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 13, 2021
@pablogsal @adorilson
bpo-41971: Fix test failure in test.test_tools.test_c_analyzer when m…
45a495a 
…utating global state (pythonGH-22652)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni