Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-41739: Fix test_logging.test_race_between_set_target_and_flush() (GH-22655) (GH-22656) #22662

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 12, 2020

The test now waits until all threads complete to avoid leaking
running threads.

Also, use regular threads rather than daemon threads.

(cherry picked from commit 13ff396)
(cherry picked from commit f5393dc)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue41739

…ythonGH-22655) (pythonGH-22656)

The test now waits until all threads complete to avoid leaking
running threads.

Also, use regular threads rather than daemon threads.

(cherry picked from commit 13ff396)
(cherry picked from commit f5393dc)

Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@vstinner vstinner merged commit 33057c7 into python:3.8 Oct 12, 2020
@miss-islington miss-islington deleted the backport-f5393dc-3.8 branch October 12, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants