New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reland][quant][eagermode] Move custom_module registration to prepare/convert_custom_config_dict (#46293) #46364

Closed

jerryzh168 wants to merge 15 commits into gh/jerryzh168/472/base from gh/jerryzh168/472/head

Contributor

jerryzh168 commented Oct 14, 2020 •

edited

Stack from ghstack:

#46364 [reland][quant][eagermode] Move custom_module registration to prepare/convert_custom_config_dict (#46293)

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

Differential Revision: D24322747


          [reland][quant][eagermode] Move custom_module registration to prepare…

96f6d85

…/convert_custom_config_dict (#46293)

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

[ghstack-poisoned]

jerryzh168 added a commit that referenced this issue


          [reland][quant][eagermode] Move custom_module registration to prepare…

9c0239d

…/convert_custom_config_dict (#46293)

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

ghstack-source-id: ddcc9e2af4c80def4381d132743103a28fd4c55a
Pull Request resolved: #46364

Contributor

facebook-github-bot commented Oct 14, 2020 •

edited

💊 CI failures summary and remediations

As of commit 96f6d85 (more details on the Dr. CI page):

1/1 failures introduced in this PR---

1 failure not recognized by patterns:

Job	Step	Action
^{docker-pytorch-linux-xenial-py3-clang5-android-ndk-r19c}	^{Check if image should be built}	🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

dr-ci bot commented Oct 15, 2020 •

edited by facebook-github-bot

💊 CI failures summary and remediations

As of commit a930903 (more details on the Dr. CI page):

1/1 failures possibly* introduced in this PR
- 1/1 non-CircleCI failure(s)---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 67 times.


          Update on "[reland][quant][eagermode] Move custom_module registration…

a7d0598

… to prepare/convert_custom_config_dict (#46293)"

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

Differential Revision: [D24322747](https://our.internmc.facebook.com/intern/diff/D24322747)

[ghstack-poisoned]

jerryzh168 added a commit that referenced this issue


          [reland][quant][eagermode] Move custom_module registration to prepare…

a0ddae6

…/convert_custom_config_dict (#46293)

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

ghstack-source-id: 9be87cbc6386da97c39355b09097530ece9ff9f4
Pull Request resolved: #46364

vkuzo approved these changes

View changes


          Update on "[reland][quant][eagermode] Move custom_module registration…

7c29c92

… to prepare/convert_custom_config_dict (#46293)"

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

Differential Revision: [D24322747](https://our.internmc.facebook.com/intern/diff/D24322747)

[ghstack-poisoned]

jerryzh168 added a commit that referenced this issue


          [reland][quant][eagermode] Move custom_module registration to prepare…

fd05b9c

…/convert_custom_config_dict (#46293)

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

ghstack-source-id: 60ab2608d0340b54fae28f3cf855f004e312fd20
Pull Request resolved: #46364


          Update on "[reland][quant][eagermode] Move custom_module registration…

fa3fd4c

… to prepare/convert_custom_config_dict (#46293)"

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

Differential Revision: [D24322747](https://our.internmc.facebook.com/intern/diff/D24322747)

[ghstack-poisoned]

jerryzh168 added a commit that referenced this issue


          [reland][quant][eagermode] Move custom_module registration to prepare…

ad433a9

…/convert_custom_config_dict (#46293)

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

ghstack-source-id: 3b00e66fcda9a2fc3e04c1e17318f27284b52f58
Pull Request resolved: #46364


          Update on "[reland][quant][eagermode] Move custom_module registration…

b33febb

… to prepare/convert_custom_config_dict (#46293)"

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

Differential Revision: [D24322747](https://our.internmc.facebook.com/intern/diff/D24322747)

[ghstack-poisoned]


          Update on "[reland][quant][eagermode] Move custom_module registration…

fb249f7

… to prepare/convert_custom_config_dict (#46293)"

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

Differential Revision: [D24322747](https://our.internmc.facebook.com/intern/diff/D24322747)

[ghstack-poisoned]

jerryzh168 added a commit that referenced this issue


          [reland][quant][eagermode] Move custom_module registration to prepare…

9d80e4c

…/convert_custom_config_dict (#46293)

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

ghstack-source-id: 7691d8a77ff6555dee1e6cf2fb6315f28a2c00c5
Pull Request resolved: #46364

jerryzh168 mentioned this pull request

[quant] Allow replacement of the custom modules in the "prepare" step #46426

Open


          Update on "[reland][quant][eagermode] Move custom_module registration…

60a0ce2

… to prepare/convert_custom_config_dict (#46293)"

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

Differential Revision: [D24322747](https://our.internmc.facebook.com/intern/diff/D24322747)

[ghstack-poisoned]


          Update on "[reland][quant][eagermode] Move custom_module registration…

bd26322

… to prepare/convert_custom_config_dict (#46293)"

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

Differential Revision: [D24322747](https://our.internmc.facebook.com/intern/diff/D24322747)

[ghstack-poisoned]


          Update on "[reland][quant][eagermode] Move custom_module registration…

a11999e

… to prepare/convert_custom_config_dict (#46293)"

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

Differential Revision: [D24322747](https://our.internmc.facebook.com/intern/diff/D24322747)

[ghstack-poisoned]

jerryzh168 added a commit that referenced this issue


          [reland][quant][eagermode] Move custom_module registration to prepare…

c311714

…/convert_custom_config_dict (#46293)

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

ghstack-source-id: 025c580592f27237b747f6db0bdca4c809538b70
Pull Request resolved: #46364


          Update on "[reland][quant][eagermode] Move custom_module registration…

e28da93

… to prepare/convert_custom_config_dict (#46293)"

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

Differential Revision: [D24322747](https://our.internmc.facebook.com/intern/diff/D24322747)

[ghstack-poisoned]

jerryzh168 added a commit that referenced this issue


          [reland][quant][eagermode] Move custom_module registration to prepare…

6fb0f91

…/convert_custom_config_dict (#46293)

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

ghstack-source-id: 6c5fa5c2324b56aea849a42d217bb3c7a968b2ef
Pull Request resolved: #46364


          Update on "[reland][quant][eagermode] Move custom_module registration…

50a32d5

… to prepare/convert_custom_config_dict (#46293)"

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

Differential Revision: [D24322747](https://our.internmc.facebook.com/intern/diff/D24322747)

[ghstack-poisoned]

jerryzh168 added a commit that referenced this issue


          [reland][quant][eagermode] Move custom_module registration to prepare…

3a4ce2f

…/convert_custom_config_dict (#46293)

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

ghstack-source-id: 2c9a7c2bf860761b08d037038c2b99efe1848677
Pull Request resolved: #46364


          Update on "[reland][quant][eagermode] Move custom_module registration…

0b23e2c

… to prepare/convert_custom_config_dict (#46293)"

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

Differential Revision: [D24322747](https://our.internmc.facebook.com/intern/diff/D24322747)

[ghstack-poisoned]


          Update on "[reland][quant][eagermode] Move custom_module registration…

27b09fa

… to prepare/convert_custom_config_dict (#46293)"

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

Differential Revision: [D24322747](https://our.internmc.facebook.com/intern/diff/D24322747)

[ghstack-poisoned]

jerryzh168 added a commit that referenced this issue


          [reland][quant][eagermode] Move custom_module registration to prepare…

ca5fe85

…/convert_custom_config_dict (#46293)

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

ghstack-source-id: 679f2e1057b465de6c63e6ff5cb566c694a924fa
Pull Request resolved: #46364


          Update on "[reland][quant][eagermode] Move custom_module registration…

5a2434b

… to prepare/convert_custom_config_dict (#46293)"

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

Differential Revision: [D24322747](https://our.internmc.facebook.com/intern/diff/D24322747)

[ghstack-poisoned]


          Update on "[reland][quant][eagermode] Move custom_module registration…

a930903

… to prepare/convert_custom_config_dict (#46293)"

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

Differential Revision: [D24322747](https://our.internmc.facebook.com/intern/diff/D24322747)

[ghstack-poisoned]

jerryzh168 added a commit that referenced this issue


          [reland][quant][eagermode] Move custom_module registration to prepare…

4c99098

…/convert_custom_config_dict (#46293)

Summary:

Test Plan: Imported from OSS

Reviewed By: raghuramank100

ghstack-source-id: c05d29d7e4ec494942ead88e6688b2c4135c1ed3
Pull Request resolved: #46364

codecov bot commented Oct 19, 2020

Codecov Report

Merging #46364 into gh/jerryzh168/472/base will decrease coverage by 0.01%.
The diff coverage is 96.29%.

@@                    Coverage Diff                     @@
##           gh/jerryzh168/472/base   #46364      +/-   ##
==========================================================
- Coverage                   68.39%   68.38%   -0.02%     
==========================================================
  Files                         411      410       -1     
  Lines                       53972    53956      -16     
==========================================================
- Hits                        36914    36896      -18     
- Misses                      17058    17060       +2

facebook-github-bot closed this in


      pytorch/pytorch@30d6875

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Oct 20, 2020

This pull request has been merged in 30d6875.

facebook-github-bot deleted the gh/jerryzh168/472/head branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment