Skip to content

DOC Shows kwargs in API signature #18576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 1, 2020

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Addresses to #18434

What does this implement/fix? Explain your changes.

This PR patches ClassDocumenter._get_signature so that the it unwraps __init__ properly.

Any other comments?

I opened this PR just in case sphinx-doc/sphinx#8234 isn't merged before the release.

Copy link
Member

@alfaro96 alfaro96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rendering looks good.

Thank you @thomasjpfan!

@glemaitre glemaitre added this to the 0.24 milestone Nov 1, 2020
@glemaitre glemaitre merged commit 7da9153 into scikit-learn:master Nov 1, 2020
@glemaitre
Copy link
Member

This solution is good for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants