Skip to content

/ Chart.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flat helpers #7806

Merged
merged 6 commits into from Sep 28, 2020
Merged

flat helpers #7806

merged 6 commits into from Sep 28, 2020

Conversation

@sgratzl
Copy link
Contributor

@sgratzl sgratzl commented Sep 18, 2020

closes #7750

breaking change:

  • bundle the helpers in a flat format in both UMD and ESM case.
  • create a helpers package that exports the helpers in commonjs and esm format

please test
sgratzl added 2 commits Sep 18, 2020
@sgratzl
generate a flat helpers package
d8b70ea
@sgratzl
move helpers built files to dist
Loading status checks…
0990211
@sgratzl sgratzl mentioned this pull request Sep 18, 2020
Closed
@sgratzl
fix tests
Loading status checks…
0dd1ee7
@kurkle
kurkle reviewed Sep 20, 2020
View changes
Copy link
Collaborator

@kurkle kurkle left a comment

Looks good to me. Need to update the migration guide too.
@etimberg
etimberg reviewed Sep 20, 2020
View changes
@etimberg etimberg mentioned this pull request Sep 22, 2020
Open
@etimberg
Copy link
Member

@etimberg etimberg commented Sep 26, 2020

@sgratzl would you be able to update the migration guide? Then we can merge this
@sgratzl
upgrade docs for flat helpers
Loading status checks…
c56c584
@sgratzl
Merge remote-tracking branch 'fork/master' into sgratzl/flathelpers
Loading status checks…
42225e2
@sgratzl
Copy link
Contributor Author

@sgratzl sgratzl commented Sep 27, 2020

done
@sgratzl
fix tests
Loading status checks…
f5a5f47
@etimberg
etimberg approved these changes Sep 27, 2020
View changes
@kurkle
kurkle approved these changes Sep 28, 2020
View changes
Copy link
Collaborator

@kurkle kurkle left a comment

Great!
@etimberg etimberg merged commit 391e4b6 into chartjs:master Sep 28, 2020
4 of 5 checks passed
4 of 5 checks passed
build (ubuntu-latest) build (ubuntu-latest)
Details
build (windows-latest) build (windows-latest)
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+3.7%) to 94.672%
Details
@etimberg etimberg added this to the Version 3.0 milestone Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg

@kurkle kurkle

Assignees
No one assigned
Labels
type: documentation
Milestone
Version 3.0
Linked issues

Successfully merging this pull request may close these issues.

to discuss: flat export of helpers in main chart.js
3 participants
@sgratzl @etimberg @kurkle
You can’t perform that action at this time.