Skip to content

/ peps

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 101: Simplified due to centralisation of switchers in the doc. #1438

Merged
merged 7 commits into from Nov 7, 2020
Merged

PEP 101: Simplified due to centralisation of switchers in the doc. #1438

merged 7 commits into from Nov 7, 2020
+17 −40

Conversation

@JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented Jun 18, 2020

Do not merge before python/cpython#20969.
@JulienPalard
Copy link
Member Author

@JulienPalard JulienPalard commented Jun 19, 2020 •
edited by brettcannon

@ambv @pablogsal @ned-deily you're concerned by this one, don't hesitate to tell me if the wording is not clear.

TL;DR: Changes to indexsidebar.html and switchers.js in all branches are no longer needed, (a change in docsbuild-script is still needed).
@ned-deily
ned-deily approved these changes Jun 22, 2020
View changes
Copy link
Member

@ned-deily ned-deily left a comment

LGTM. Thanks for making all those changes. Once the doc build changes are fully deployed, this should be merged as well.
@brettcannon brettcannon marked this pull request as draft Sep 21, 2020
@JulienPalard
Doing Python Releases 101: Simplified due to centralisation of langua…
d5f8793 
…ge switchers in the doc.
@JulienPalard
backslash not needed.
8b69297
@JulienPalard
FIX: Missing backslash.
d8c0578
@JulienPalard
consistency
abf05b2
@JulienPalard
Factor 3 links.
ad4cd7a
@JulienPalard
FIX: Ugly apostrophes after [1].
82ae4b2
@JulienPalard
Missing
Loading status checks…
24784f9
@JulienPalard JulienPalard force-pushed the JulienPalard:doc-switchers branch from 9e7e767 to 24784f9 Nov 7, 2020
@JulienPalard JulienPalard changed the title [WIP] PEP 101: Simplified due to centralisation of switchers in the doc. PEP 101: Simplified due to centralisation of switchers in the doc. Nov 7, 2020
@JulienPalard JulienPalard marked this pull request as ready for review Nov 7, 2020
@JulienPalard JulienPalard merged commit f2213d7 into python:master Nov 7, 2020
1 check passed
1 check passed
build
Details
gaborbernat added a commit to gaborbernat/peps that referenced this pull request Dec 13, 2020
@JulienPalard @gaborbernat
PEP 101: Simplified due to centralisation of switchers in the doc. (p…
Verified
This commit was signed with a verified signature.
gaborbernat Bernát Gábor
GPG key ID: 389A324926656E0D Learn about signing commits
b23a8c2 
…ython#1438)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@JulienPalard @ned-deily @the-knights-who-say-ni