Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the melkman anlgorithm for computing convex hulls #2916

Open
wants to merge 5 commits into
base: master
from
Open

Implement the melkman anlgorithm for computing convex hulls #2916

wants to merge 5 commits into from

Conversation

@SimonLammer
Copy link

@SimonLammer SimonLammer commented Oct 6, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Since the file didn't contain type hints at all, I didn't add them for this algorithm.
Is this file the correct place for the algorithm? It is not a divide and conquer algorithm, but it is a convex_hull algorithm.
SimonLammer added 3 commits Oct 6, 2020
@SimonLammer
Implement the melkman anlgorithm for computing convex hulls
bda7b7b
@SimonLammer
Link melkman algorithm description
Loading status checks…
6492d4b
@SimonLammer
Format melkman algorithm code
Loading status checks…
7e0fe0e
@SimonLammer SimonLammer mentioned this pull request Oct 8, 2020
Open
0 of 2 tasks complete
@poyea
poyea reviewed Oct 8, 2020
View changes
divide_and_conquer/convex_hull.py Outdated Show resolved Hide resolved
@SimonLammer
Add type hints to functions
Loading status checks…
3a0316f
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 8, 2020

Travis tests have failed

Hey @SimonLammer,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e8ee7930-0992-11eb-b9d6-41d4da7e5060
@SimonLammer SimonLammer force-pushed the SimonLammer:convex_hull-melkman branch from c9371a0 to bc2efde Oct 8, 2020
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 8, 2020

Travis tests have failed

Hey @SimonLammer,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 664c6120-0999-11eb-b9d6-41d4da7e5060
@SimonLammer SimonLammer force-pushed the SimonLammer:convex_hull-melkman branch from bc2efde to 7162412 Oct 8, 2020
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 8, 2020

Travis tests have failed

Hey @SimonLammer,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: d36267a0-0999-11eb-b9d6-41d4da7e5060
@SimonLammer
Fix build errors
Loading status checks…
db5b1fa
@SimonLammer SimonLammer force-pushed the SimonLammer:convex_hull-melkman branch from 7162412 to db5b1fa Oct 8, 2020
@SimonLammer
Copy link
Author

@SimonLammer SimonLammer commented Oct 11, 2020

@poyea Is there anything else I should to revise?
@SimonLammer
Copy link
Author

@SimonLammer SimonLammer commented Oct 15, 2020

@poyea ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@SimonLammer @TravisBuddy @poyea
You can’t perform that action at this time.