Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typehints ciphers and bool alg #3264

Merged
merged 15 commits into from Oct 16, 2020
Merged

Add typehints ciphers and bool alg #3264

merged 15 commits into from Oct 16, 2020

Conversation

@jenia90
Copy link
Contributor

@jenia90 jenia90 commented Oct 13, 2020

#2128 #2510 Added missing type hints to cipher and and bool alg python files.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
github-actions and others added 4 commits Oct 9, 2020
github-actions github-actions
updating DIRECTORY.md
5017aa2
@jenia90
Merge remote-tracking branch 'origin/master'
0c02224
github-actions github-actions
updating DIRECTORY.md
1144496
@jenia90
Merge remote-tracking branch 'upstream/master' into jenia90/2128_add_…
216d606 
…typehints_cyphers_and_bool_alg
@jenia90 jenia90 requested a review from cclauss as a code owner Oct 13, 2020
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 13, 2020

Travis tests have failed

Hey @jenia90,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 2c7a20d0-0d78-11eb-9111-f326d0cb7f09
@jenia90
Fixed accidental commit of file I have't touched
Loading status checks…
7e45b78
@jenia90 jenia90 force-pushed the jenia90:jenia90/2128_add_typehints_cyphers_and_bool_alg branch from b156447 to 7e45b78 Oct 13, 2020
github-actions github-actions
fixup! Format Python code with psf/black push
Loading status checks…
d412b27
@github-actions github-actions bot force-pushed the jenia90:jenia90/2128_add_typehints_cyphers_and_bool_alg branch from c971ce1 to d412b27 Oct 13, 2020
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 13, 2020

Travis tests have failed

Hey @jenia90,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 36b19bc0-0d7b-11eb-9111-f326d0cb7f09
jenia90 and others added 2 commits Oct 14, 2020
@jenia90
Merge remote-tracking branch 'upstream/master' into jenia90/2128_add_…
Loading status checks…
9756c10 
…typehints_cyphers_and_bool_alg
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
08c4e27
@jenia90 jenia90 changed the title Jenia90/2128 add typehints ciphers and bool alg Add typehints ciphers and bool alg Oct 14, 2020
jenia90 and others added 2 commits Oct 14, 2020
@jenia90
Merge remote-tracking branch 'upstream/master'
0f9c80e
github-actions github-actions
updating DIRECTORY.md
8ad6952
@poyea
poyea reviewed Oct 15, 2020
View changes
Copy link
Member

@poyea poyea left a comment

I've made some comments for you. Please re-check some of them (maybe I made a mistake) before we have this landed. Very nice work!! Thank you for your pull request!🤩
boolean_algebra/quine_mc_cluskey.py Outdated Show resolved Hide resolved
ciphers/decrypt_caesar_with_chi_squared.py Outdated Show resolved Hide resolved
ciphers/rsa_key_generator.py Outdated Show resolved Hide resolved
@poyea poyea self-assigned this Oct 15, 2020
jenia90 added 3 commits Oct 15, 2020
@jenia90
Fixed some suggested coding style issues
Loading status checks…
0d4c812
@jenia90
Merge remote-tracking branch 'upstream/master'
36fd739
@jenia90
Merge branch 'master' into jenia90/2128_add_typehints_cyphers_and_boo…
Loading status checks…
d5f2667 
…l_alg
@jenia90
Copy link
Contributor Author

@jenia90 jenia90 commented Oct 15, 2020

@poyea any suggestion how I can fix rsa_key_generator.py not being able to import modules from ciphers folder? It seems like this is the only thing stopping pre-commit from passing, however I can't see any problem with the way it is currently written.
poyea added 2 commits Oct 16, 2020
@poyea
Update rsa_key_generator.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
17c4757
@poyea
Update rsa_key_generator.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fbd90e9
@poyea
poyea approved these changes Oct 16, 2020
View changes
Copy link
Member

@poyea poyea left a comment

Thank you for your pull request!🤩
@poyea poyea added the OK to merge label Oct 16, 2020
@poyea poyea merged commit 9d745b6 into TheAlgorithms:master Oct 16, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
@jenia90 jenia90 deleted the jenia90:jenia90/2128_add_typehints_cyphers_and_bool_alg branch Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea

@cclauss cclauss

Assignees

@poyea poyea

Labels
OK to merge hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@jenia90 @TravisBuddy @poyea
You can’t perform that action at this time.