Skip to content

added PascalTriangle.py.Any constructive criticism are welcome, which can help me grow.Happy hacking! #3349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

added PascalTriangle.py.Any constructive criticism are welcome, which can help me grow.Happy hacking! #3349

wants to merge 7 commits into from

Conversation

mahimonga
Copy link

@mahimonga mahimonga commented Oct 15, 2020 •
edited
Loading

added PascalTriangle.py with problem statement brief explanation and my newbie solution.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@mahimonga
added PascalTriangle.py.
a39d6fd 
added PascalTriangle.py with problem statement brief explanation and my newbie solution.
@TravisBuddy
Copy link

Travis tests have failed

Hey @mahimonga,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 8ecf8d00-0f27-11eb-9bff-abeacd856cb9

mahimonga
mahimonga commented Oct 17, 2020
View reviewed changes
Copy link
Author

@mahimonga mahimonga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check now? I think the uppercase letters were causing the problem.

@mahimonga
Copy link
Author

@TravisBuddy Can you please help why there is still an error in this?

@mahimonga
Copy link
Author

@TravisBuddy @darkstar @erdenezul @vovapi can anyone of you please help me with why the merging is still blocked. Thank you in advance.
If you approve this or can you please accept it with hacktober labels.
Happy hacking!

@stale
Copy link

stale bot commented Nov 21, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Nov 21, 2020
@stale
Copy link

stale bot commented Dec 10, 2020

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

@stale stale bot closed this Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale Used to mark an issue or pull request stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahimonga @TravisBuddy