Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Update getting-started.md #515
Conversation
| @@ -31,13 +34,13 @@ | |||
| * In a clustering environment, the `GHE_EXTRA_SSH_OPTS` key must be configured | |||
| with the `-i <abs path to private key>` SSH option. | |||
|
|
|||
| 3. Add the backup host's SSH key to the GitHub appliance as an *Authorized SSH | |||
| 3. Add the backup host's (in this case your computer) SSH key to the GitHub appliance as an *Authorized SSH | |||
lildude
Oct 3, 2019
Member
I'm not sure I understand this addition. To me, this addition suggests the SSH key the admin user uses to connect to the backup host is the one that needs to be added to the appliance, which isn't necessarily correct.
We encourage customers to use a dedicated host for their backups and if they're using good practices, the backup user will have their own SSH key which won't be the same as the one the admin uses.
Could you explain this addition a bit more so I can understand the background behind its addition.
sennap
Dec 22, 2019
Author
hey @lildude
I'm having a hard time remembering what my logic was there and I agree with what you're saying. It doesn't really make sense so I'm removing this line!
|
|
|
@sennap would you still like this PR? |
As someone who went through this process for the first time, I wanted to make note of some things in the guide that I was confused by, and propose some wording that might help save others from questions:
cc @skhalife @glennwester @nielspineda