feature: Add C# 8 Nullability #2428
Conversation
made warnings errors
nulled PropertyChangingEvenHandler
| @@ -83,14 +85,14 @@ public IScheduler Scheduler | |||
| /// Gets or sets a command which will navigate back to the previous element in the stack. | |||
| /// </summary> | |||
| [IgnoreDataMember] | |||
| public ReactiveCommand<Unit, Unit> NavigateBack { get; protected set; } | |||
| public ReactiveCommand<Unit, Unit>? NavigateBack { get; protected set; } | |||
There was a problem hiding this comment.
Don't think these ones should ever be null. It's due to the SetupRx() method being called in the constructor. Let's just make sure they are constructed.
src/ReactiveUI/RxApp.cs
Outdated
| private static IScheduler _unitTestMainThreadScheduler; | ||
| private static IScheduler _mainThreadScheduler; | ||
| private static IObserver<Exception> _defaultExceptionHandler; | ||
| private static IScheduler? _unitTestMainThreadScheduler; |
There was a problem hiding this comment.
Not sure if we want these to be nullable. Again probably should be set from the static constructor some how.
Codecov Report
@@ Coverage Diff @@
## main #2428 +/- ##
==========================================
- Coverage 52.67% 51.73% -0.95%
==========================================
Files 114 114
Lines 4459 4525 +66
Branches 688 793 +105
==========================================
- Hits 2349 2341 -8
- Misses 1926 1959 +33
- Partials 184 225 +41
Continue to review full report at Codecov.
|
RLittlesII
force-pushed
the
feature/nullable
branch
from
7c28826 to
7664500
Compare
| @@ -13,6 +13,7 @@ | |||
| using System.Runtime.Serialization; | |||
| using DynamicData; | |||
| using DynamicData.Binding; | |||
| #pragma warning disable 8618 | |||
There was a problem hiding this comment.
Remove SetupRX() and put it in the constructor, suspect that will make your nullables work without the need for this pragma.
glennawatson
changed the title
glennawatson
changed the title
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What kind of change does this PR introduce?
Adds C# Nullability Support
What is the current behavior?
Not nullability support
What is the new behavior?
All the nulls!
What might this PR break?
A lot? Technically nothing that isn't already potentially broken.
Please check if the PR fulfills these requirements
Other information: