Skip to content

/ vue-apollo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using prefetch or enabled in SSR leads to endless loading #940

Open
negezor opened this issue Mar 20, 2020 · 5 comments
Open

Using prefetch or enabled in SSR leads to endless loading #940

negezor opened this issue Mar 20, 2020 · 5 comments
Labels
pending triage

Comments

@negezor
Copy link

@negezor negezor commented Mar 20, 2020 •
edited

Describe the bug
Using the prefetch or enabled options in useQuery on the server causes endless loading.

To Reproduce
Steps to reproduce the behavior:

  1. Use SSR
  2. Add option prefetch or enabled
  3. Watch endless loading

Expected behavior
Disabling the request before the client waits for the necessary data.

Versions
vue: 2.6.11
vue-apollo: 3.0.3
apollo-client: 2.6.8
@vue/composition-api: 0.5.0
@vue/apollo-composable: 4.0.0-alpha.7

Additional context
The problem is related to not resolved promise in onServerPrefetch.
@negezor
Copy link
Author

@negezor negezor commented Jun 25, 2020

Related #1001
@beeplin
Copy link

@beeplin beeplin commented Jun 25, 2020 •
edited

This is not necessarily related to #1001. 0.5.0 also freezes in SSR if the initial value of enabled is false. I guess that on the server side the ref values are not reactive at all, so all enabled values are fixed to their initial values, and if the values are false, the whoel queries are frozen. Likewise, all computeds only have initial values effective, and all lazy watchs never work.
@brunomperes
Copy link

@brunomperes brunomperes commented Sep 3, 2020

Also happening on

Versions
vue: 2.6.12
vue-apollo: not installed
apollo-client: 3.1.2
@vue/composition-api: 1.0.0-beta.11
@vue/apollo-composable: 4.0.0-alpha.10

Have you found any workaround?
@brunomperes brunomperes mentioned this issue Sep 23, 2020
Open
javiertury added a commit to javiertury/vue-apollo that referenced this issue Oct 4, 2020
@javiertury
fix: unresolved promises in ssr (vuejs#940)
4c18785
javiertury added a commit to javiertury/vue-apollo that referenced this issue Oct 4, 2020
@javiertury
fix: unresolved promises in ssr (vuejs#940)
a3afbb7
javiertury added a commit to javiertury/vue-apollo that referenced this issue Oct 4, 2020
@javiertury
fix: unresolved promises in ssr (vuejs#940)
c04f9fc
javiertury added a commit to javiertury/vue-apollo that referenced this issue Oct 4, 2020
@javiertury
fix: unresolved promises in ssr (vuejs#940)
2d4499d
@javiertury javiertury mentioned this issue Oct 4, 2020
Merged
Akryum pushed a commit that referenced this issue Oct 15, 2020
@javiertury
fix: unresolved promises in ssr (#940) (#1069)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8a71443
@seanaye
Copy link

@seanaye seanaye commented Oct 19, 2020

Any updates on this?
@javiertury
Copy link

@javiertury javiertury commented Oct 20, 2020

@seanaye It should be solved in version v4.0.0-alpha.12, which was released 2 days ago.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pending triage
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@javiertury @brunomperes @negezor @beeplin @seanaye
You can’t perform that action at this time.