Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unresolved promises in ssr (#940) #1069

Merged
merged 1 commit into from Oct 15, 2020

Conversation

@javiertury
Copy link

@javiertury javiertury commented Oct 4, 2020

Fixes #940

After evaluating a few alternatives, this one performed reliably on all my components.

  • If onServerPrefetch the query is not enabled or prefetch is disabled, resolve firstResult
  • If start is cancelled and a firstResult is pending, resolve firstResult
  • If stop is called and firstResult is pending, resolve firstResult

The remaining cases are coverd with the old conditions.

  • If query returns an error and firstResult is pending, reject with firstReject
  • If query completes successfully and firstResult is pending, resolve firstResult
@Akryum Akryum merged commit 8a71443 into vuejs:v4 Oct 15, 2020
6 checks passed
6 checks passed
Header rules No header rules processed
Details
Pages changed 80 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
ci/circleci: build Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.