Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upupdate(10.1): migration to remove solution style tsconfig is not run #18744
Comments
I thought that perhaps Scully was causing issues since it had the older versions, but removing it actually resulted in an error (rather than things working properly):
|
WorkaroundWith my Scully libs put back in and everything restored to the original state:
Your global Angular CLI version (10.1.0) is greater than your local
version (10.0.8). The local Angular CLI version is used.
To disable this warning use "ng config -g cli.warnings.versionMismatch false".
The installed local Angular CLI version is older than the latest stable version.
Installing a temporary version to perform the update.
Installing packages for tooling via npm.
Installed packages for tooling via npm.
Repository is not clean. Update changes will be mixed with pre-existing changes.
Using package manager: 'npm'
Collecting installed dependencies...
Found 54 dependencies.
Fetching dependency metadata from registry...
Updating package.json with dependency @angular-devkit/build-angular @ "0.1001.0" (was "0.1000.8")...
Updating package.json with dependency @angular/cli @ "10.1.0" (was "10.0.8")...
UPDATE package.json (3757 bytes)
✔ Packages installed successfully.
** Executing migrations of package '@angular/cli' **
❯ Removing "Solution Style" TypeScript configuration file support.
DELETE tsconfig.base.json
UPDATE tsconfig.json (795 bytes)
UPDATE tsconfig.spec.json (385 bytes)
UPDATE projects/angularjs.xlts.dev/tsconfig.app.json (190 bytes)
UPDATE projects/xlts.dev/tsconfig.app.json (190 bytes)
Migration completed. |
QuestionsCan the situation with
|
I am encountering a similar if not the same problem. I have tsconfig.base.json(but no tsconfig.json) in the root of my project and get a failure of
every time I try to run
|
@cwhaught that seems like a separate issue. Can you please open a new issue for it? |
Apologies @Splaktar, I thought I saw the same error in your comments at first glance. |
Hi @Splaktar, Find below the answers to your questions, feel free to ask more
This should be handled with the new version of schematics, aka schematics runtime, which is still currently in it's early design phase.
Maybe we can issue a warning when the installed
While Side note: I'd suggest that a lock file maintain is done periodically. Overtime when packages are added and updated, the presence of a lock file will hinder package hoisting and deduping. There are two quick ways to do such maintainance:
|
I ran the following command and it worked out:
As I forgot to use |
Command (mark with an
x
)Is this a regression?
No
Description
Running
ng update @angular/cli
to update to v10.1.0 from v10.0.8 does not run the migration to remove solution style tsconfigs.ng update @angular/cli
tsconfig.base.json
still existsNone
Before
After
Anything else relevant?
I'm not sure why it's showing
9.1.12
for@angular-devkit/core
,@angular-devkit/schematics
, and@schematics/angular
.Here's the output of
npm ls @angular-devkit/core
:Here's the output of
npm ls @schematics/angular
: