Skip to content

Additional Yarn E2E test improvements/fixes #19126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 19, 2020

Conversation

clydin
Copy link
Member

@clydin clydin commented Oct 19, 2020

Please see individual commits.

A separate directory within the ramdisk is now created for each E2E step to prevent the E2E tests from accidently reusing files from a previous step.
…date E2E

Previously, the package manager would default to using npm during the update of the yarn workspace test project.  This can cause undefined package behavior and did not accurately represent a yarn workspace environment.
…tall task

The manager that is being used to perform the package installation will now be shown during the installation.  This provides more insight to the user as well as providing additional troubleshooting information in the event of a failure.
@google-cla google-cla bot added the cla: yes label Oct 19, 2020
@clydin clydin added the target: patch This PR is targeted for the next patch release label Oct 19, 2020
@clydin clydin requested a review from alan-agius4 October 19, 2020 17:28
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 19, 2020
@alan-agius4 alan-agius4 merged commit 445fe1d into angular:master Oct 19, 2020
@clydin clydin deleted the fix-yarn-update branch October 19, 2020 18:12
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants