bpo-33466: Support compiling Objective-C++ (“.mm”) files #6767
Conversation
At the moment, Objective-C++ files suffixed with `.mm` are unrecognized; however, other parts of `distutils` suggest support for compiling these files (e.g. the suffix list found in https://github.com/python/cpython/blob/7ec8f28656ea9d84048e9b5655375c6a74a59f53/Lib/distutils/extension.py#L193). Adding the `".mm"` string to the `src_extensions` list fixes this inequity.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request Thanks again to your contribution and we look forward to looking at it! |
|
It looks like b.p.o. has acknowledged my signature of the CLA: |
|
Patch looks good to me. P.S. I'm not merging at this time because this would the first patch I'd merge in a long time and I need to check the devguide to ensure I follow the right process. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
@fish2000, it looks like your pull request was approved by a core developer and had some changes requested by another. If you're able to address the code review, perhaps this can be merged soon. Thanks! |
|
@ronaldoussoren would you like to pronounce on this? This looks innocuous and could be merged after a manual test (to confirm that it works) and a quick doc addition. On the other hand, distutils is strongly deprecated and apparently on its way out, people have been advised to use setuptools or other build tools for years, so maybe distutils PRs should be closed and patches redirected to setuptools. |
At the moment, Objective-C++ files suffixed with
.mmare unrecognized; however, other parts ofdistutilssuggest support for compiling these files – e.g. the suffix list found inextension.py:cpython/Lib/distutils/extension.py
Line 193 in 7ec8f28
Adding the
".mm"string to thesrc_extensionslist fixes this inequity.https://bugs.python.org/issue33466