Skip to content

/ Javascript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorial #460

Open
wants to merge 1 commit into
base: master
from
Open

factorial #460

wants to merge 1 commit into from

Conversation

@sunny5559
Copy link

@sunny5559 sunny5559 commented Oct 11, 2020

to din factorial of a number

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@sunny5559
factorial
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
49a10e8 
to din factorial of a number
@pomkarnath98
pomkarnath98 reviewed Oct 11, 2020
View changes
Copy link
Contributor

@pomkarnath98 pomkarnath98 left a comment

Thanks for your contribution. But I'd like to pay your attention to a few things.

  • Please read CONTRIBUTING.md.

You are not following these rules:

  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
@pomkarnath98 pomkarnath98 self-requested a review Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomkarnath98 pomkarnath98

Assignees
No one assigned
Labels
Beginner Changes Required enhancement good first issue
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@sunny5559 @pomkarnath98 @itsvinayak
You can’t perform that action at this time.