Skip to content

exclusion is not supported by notification filters #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2020

Conversation

mchelen-gov
Copy link
Contributor

@mchelen-gov mchelen-gov commented Oct 21, 2020

Why:

The custom filter docs do not mention this limitation.

What's being changed:

Check off the following:

@welcome
Copy link

welcome bot commented Oct 21, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

Thanks so much @mchelen-gov! I'll get this triaged for review 🌟

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Oct 23, 2020
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mchelen-gov - Thanks for taking the time to submit this pull request. We really appreciate your help improving GitHub documentation. I've suggested a small change. Thanks again. 👍

@janiceilene janiceilene added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 27, 2020
…hub/managing-notifications-from-your-inbox.md

Co-authored-by: hubwriter <hubwriter@github.com>
@mchelen-gov
Copy link
Contributor Author

mchelen-gov commented Nov 2, 2020

commited suggestion, thanks!

@mchelen-gov mchelen-gov requested a review from hubwriter November 3, 2020 16:05
@hubwriter
Copy link
Contributor

Thanks @mchelen-gov - merging this now.

@hubwriter hubwriter merged commit d6d3433 into github:main Nov 4, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants