Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect library editing & enable warnings #291

Open
PaulStoffregen opened this issue Sep 13, 2018 · 1 comment
Open

Detect library editing & enable warnings #291

PaulStoffregen opened this issue Sep 13, 2018 · 1 comment
Labels
Milestone

Comments

@PaulStoffregen
Copy link

@PaulStoffregen PaulStoffregen commented Sep 13, 2018

Perhaps arduino-builder could detect when someone is editing a library's files, rather than just using an installed copy. This might be done by comparing timestamps on library source files to library.properties or other non-source files. Or maybe the presence of a .git folder is enough?

The idea would be to turn on all compiler warnings when building that library. Ordinary users would not be bothered, and library authors would not be bothered by warnings from other libraries, only their's.

Over time, this could lead to a significant improvement in the quality of library code over the entire Arduino ecosystem.

Previously mentioned here.

@facchinm
Copy link
Member

@facchinm facchinm commented Sep 14, 2018

Completely agree but I'm not sure how we should achieve this; presence of .git folder could be a good candidate but the best would be also tracking if the repo is "dirty". However, in this case the switch wouldn't trigger if you commit before testing 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.