Skip to content

/ coreui-vue

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSidebarNavItem] Icon props are not passed to CIcon #76

Closed
CVeniamin opened this issue Apr 2, 2020 · 2 comments
Closed

[CSidebarNavItem] Icon props are not passed to CIcon #76

CVeniamin opened this issue Apr 2, 2020 · 2 comments

Comments

@CVeniamin
Copy link
Contributor

@CVeniamin CVeniamin commented Apr 2, 2020 •
edited

I am trying to adjust the size of icon in the CSidebarNavItem by passing icon as an object, such as

<CSidebarNavItem 
  name="Dashboard" 
   to="/dashboard" 
   :icon="{name: 'cil-chart', size: '4xl'}"
/>

however the size prop is not passed to CIcon.
However, creating a CIcon with the size prop works just fine

<CIcon name="cil-chart" size="4xl"/>

After searching through the code I saw that CIconRaw is imported instead of CIcon

coreui-vue/src/components/template/CSidebarNavDropdown.vue

Line 19 in ad9f36c

import CIcon from '@coreui/icons-vue/src/CIconRaw.vue'

Could it be that importing CIconRaw instead of CIcon is to blame here?
@woothu
Copy link
Contributor

@woothu woothu commented Apr 2, 2020 •
edited

Hi, thank you for the report!

in fact, it doesn't work because 'customClasses' is set to 'c-sidebar-nav-icon' inside CSidebarNavItem overriding size prop in CIcon.

Hotfix:

<CSidebarNavItem 
  name="Dashboard" 
   to="/dashboard" 
   :icon="{name: 'cil-chart', customClasses: 'c-sidebar-nav-icon c-icon c-icon-4xl'}"
/>

We will think of a better solution, and fixing documentation of CIcon (it doesn't say that using customClasses overrides size prop).
@woothu woothu closed this Apr 2, 2020
@CVeniamin
Copy link
Contributor Author

@CVeniamin CVeniamin commented Apr 2, 2020

@woothu, thank you for the hotfix!
woothu added a commit that referenced this issue Apr 14, 2020
@woothu
fix: CSidebarNavItem: allow adding 'size' prop in 'icon' object #76
Loading status checks…
a1a8203
woothu added a commit that referenced this issue May 5, 2020
@woothu
fix: CSidebarNavDropdown: allow adding 'size' prop in 'icon' object #76
30ae677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@CVeniamin @woothu
You can’t perform that action at this time.