Skip to content

/ cube.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Server Core Options, don't allow typos while passing options #1089

Merged
merged 1 commit into from Sep 14, 2020
Merged

Validate Server Core Options, don't allow typos while passing options #1089

merged 1 commit into from Sep 14, 2020

Conversation

@RusovDmitriy
Copy link
Contributor

@RusovDmitriy RusovDmitriy commented Sep 13, 2020

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

Validate Server Core Options, don't allow typos while passing options
@RusovDmitriy
add server-core options validate
Loading status checks…
d7a9ccd
@RusovDmitriy RusovDmitriy changed the title add server-core options validate Validate Server Core Options, don't allow typos while passing options Sep 13, 2020
@RusovDmitriy RusovDmitriy mentioned this pull request Sep 14, 2020
Closed
3 of 4 tasks complete
@paveltiunov paveltiunov merged commit 5580018 into cube-js:master Sep 14, 2020
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: react_dashboard_guide Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-mssql Your tests passed on CircleCI!
Details
guides Workflow: guides
Details
lint Workflow: lint
Details
test Workflow: test
Details
@ovr ovr mentioned this pull request Sep 16, 2020
Merged
0 of 4 tasks complete
@sajdre sajdre mentioned this pull request Sep 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@RusovDmitriy @paveltiunov
You can’t perform that action at this time.