Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update bazel dependencies and configuration #15291

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@clydin
Copy link
Member

@clydin clydin commented Aug 9, 2019

This leverages the configuration from FW as much as possible.
Bazel updated to 0.28.1
Rules for nodejs/typescript/karma/jasmine updated to 0.35.0

Ran into issues using the managed directories with yarn workspaces so that is disabled in the yarn install rule for now.

@googlebot googlebot added the cla: yes label Aug 9, 2019
@clydin clydin force-pushed the clydin:update-bazel branch 2 times, most recently from 71cf56d to 23db5b3 Aug 9, 2019
@clydin clydin requested a review from josephperrott Aug 9, 2019
.bazelrc Outdated Show resolved Hide resolved
.bazelrc Show resolved Hide resolved
.bazelrc Outdated Show resolved Hide resolved
WORKSPACE Outdated Show resolved Hide resolved
WORKSPACE Show resolved Hide resolved
@clydin clydin force-pushed the clydin:update-bazel branch from 23db5b3 to 25688fd Aug 11, 2019
Copy link
Member

@josephperrott josephperrott left a comment

LGTM

.bazelrc Show resolved Hide resolved
This leverages the configuration from FW where possible.
Bazel updated to 28.1
Rules for nodejs/typescript/karma/jasmine updated to 0.35.0
@clydin clydin force-pushed the clydin:update-bazel branch from 25688fd to 215d755 Aug 12, 2019
@mgechev mgechev merged commit 920ee85 into angular:master Aug 12, 2019
16 of 18 checks passed
16 of 18 checks passed
ci/angular: merge status Status "ci/circleci: e2e-cli-ivy" is failing
ci/circleci: e2e-cli-ivy Your tests failed on CircleCI
Details
ci/angular: size No size change against base branch.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-ivy-snapshots Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-snapshots Your tests passed on CircleCI!
Details
ci/circleci: flake-jail Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-browsers Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: test-large-ivy Your tests passed on CircleCI!
Details
ci/circleci: test-win Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
@clydin clydin deleted the clydin:update-bazel branch Aug 12, 2019
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Sep 13, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.