Add extended and supplement combining marks ranges #3932
Merged
Conversation
|
|
|
Thank you @dracos! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I wasn't sure if there was a reason the same variables were defined in multiple files, so I left them as is, and added in all relevant locations. Fixes #3930.
This adds tne other combining marks ranges, though please note that this regex does not fully follow the UAX 29 algorithm for counting grapheme clusters which is quite a bit more complex. But this is hopefully a little improvement :)