Skip to content

/ EcomDev_PHPUnit

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vfsStream git submodule from repo #248

Open
wants to merge 1 commit into
base: dev
from
Open

Remove vfsStream git submodule from repo #248

wants to merge 1 commit into from

Conversation

@hakre
Copy link

@hakre hakre commented Mar 31, 2015

mikey179/vfsStream is already part of the dependencies (via
"phpunit/phpunit": "4.1.*")

See #231, #222
@hakre
Remove vfsStream git submodule from repo
Loading status checks…
6ea6e98 
mikey179/vfsStream is already part of the dependencies (via
"phpunit/phpunit": "4.1.*")

It is also enforced via .travis/composer.json.

See #231, #222
@hakre hakre force-pushed the hakre:hakre/vfsstream-gitsubmodule-remove branch from d8a7abe to 6ea6e98 Mar 31, 2015
@hakre hakre closed this Mar 31, 2015
@hakre hakre deleted the hakre:hakre/vfsstream-gitsubmodule-remove branch Mar 31, 2015
@hakre hakre restored the hakre:hakre/vfsstream-gitsubmodule-remove branch Mar 31, 2015
@hakre hakre reopened this Mar 31, 2015
@cgrossde
Copy link

@cgrossde cgrossde commented Nov 26, 2015

The vfsStream dependency is still missing in composer.json and leads to an error.

[ErrorException]
  Source /vagrant/magento/vendor/ecomdev/ecomdev_phpunit/vendor/mikey179/vfsStream does not exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@hakre @cgrossde
You can’t perform that action at this time.