Skip to content

/ runtime

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update "LICENSE.txt" so that it's recognized as MIT" #37626

Merged
merged 2 commits into from Jun 9, 2020
Merged

Revert "Update "LICENSE.txt" so that it's recognized as MIT" #37626

merged 2 commits into from Jun 9, 2020

Conversation

@stephentoub
Copy link
Member

@stephentoub stephentoub commented Jun 9, 2020 •
edited

Reverts #36744

All PRs to dotnet/runtime are now failing with:

error : License file content '/Users/runner/runners/2.169.1/work/1/s/LICENSE.TXT' doesn't match the expected license '/Users/runner/runners/2.169.1/work/1/s/.packages/microsoft.dotnet.arcade.sdk/5.0.0-beta.20280.1/tools/Licenses/MIT.txt'.

cc: @richlander, @terrajobst, @jkotas
@stephentoub
Revert "Update "LICENSE.txt" so that it's recognized as MIT"
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
97ef08e
@msftbot
Copy link
Contributor

@msftbot msftbot bot commented Jun 9, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.
@stephentoub
Copy link
Member Author

@stephentoub stephentoub commented Jun 9, 2020

(@ViktorHofer, if changes to LICENSE.TXT can cause builds to fail, we need to ensure at least one relevant CI leg runs when it's changed.)
@safern
Add LICENSE.TXT to global build
Loading status checks…
5f617fd
@safern
Copy link
Member

@safern safern commented Jun 9, 2020

@stephentoub I pushed to this branch if that's OK to add that validation. If we want to keep it as a separate change I can of course put it in a new PR.
@safern
safern approved these changes Jun 9, 2020
View changes
@safern
Copy link
Member

@safern safern commented Jun 9, 2020

Feel free to merge in order to unblock PRs if you're OK with me adding the change to run the global build on PRs here.
@safern safern mentioned this pull request Jun 9, 2020
Merged
@stephentoub stephentoub merged commit ed3d384 into master Jun 9, 2020
96 of 100 checks passed
96 of 100 checks passed
runtime Build #20200608.141 had test failures
Details
runtime-live-build Build #20200608.131 failed
Details
runtime-live-build (Build Windows_NT x86 release Runtime_Debug) Build Windows_NT x86 release Runtime_Debug failed
Details
runtime (Installer Build and Test coreclr Linux_musl_x64 Release) Installer Build and Test coreclr Linux_musl_x64 Release was canceled
Details
dotnet-runtime-perf Build #20200608.140 succeeded
Details
dotnet-runtime-perf (Checkout) Checkout succeeded
Details
dotnet-runtime-perf (CoreCLR Product Build Linux x64 release) CoreCLR Product Build Linux x64 release succeeded
Details
dotnet-runtime-perf (CoreCLR Product Build Windows_NT x64 release) CoreCLR Product Build Windows_NT x64 release succeeded
Details
dotnet-runtime-perf (CoreCLR Product Build Windows_NT x86 release) CoreCLR Product Build Windows_NT x86 release succeeded
Details
dotnet-runtime-perf (Libraries Build Linux x64 Release) Libraries Build Linux x64 Release succeeded
Details
dotnet-runtime-perf (Libraries Build Windows_NT x64 Release) Libraries Build Windows_NT x64 Release succeeded
Details
dotnet-runtime-perf (Libraries Build Windows_NT x86 Release) Libraries Build Windows_NT x86 Release succeeded
Details
dotnet-runtime-perf (Mono Product Build Linux x64 release) Mono Product Build Linux x64 release succeeded
Details
dotnet-runtime-perf (Performance Linux x64 release coreclr net5.0) Performance Linux x64 release coreclr net5.0 succeeded
Details
dotnet-runtime-perf (Performance Linux x64 release mono net5.0) Performance Linux x64 release mono net5.0 succeeded
Details
dotnet-runtime-perf (Performance Windows_NT x64 release coreclr net5.0) Performance Windows_NT x64 release coreclr net5.0 succeeded
Details
dotnet-runtime-perf (Performance Windows_NT x86 release coreclr net5.0) Performance Windows_NT x86 release coreclr net5.0 succeeded
Details
license/cla All CLA requirements met.
Details
runtime (Build Android arm Release AllSubsets_Mono) Build Android arm Release AllSubsets_Mono succeeded
Details
runtime (Build Android arm64 Debug AllSubsets_Mono) Build Android arm64 Debug AllSubsets_Mono succeeded
Details
runtime (Build Android x64 Release AllSubsets_Mono) Build Android x64 Release AllSubsets_Mono succeeded
Details
runtime (Build Android x86 Debug AllSubsets_Mono) Build Android x86 Debug AllSubsets_Mono succeeded
Details
runtime (Build Browser wasm Debug AllSubsets_Mono) Build Browser wasm Debug AllSubsets_Mono succeeded
Details
runtime (Build Linux arm Debug AllSubsets_Mono) Build Linux arm Debug AllSubsets_Mono succeeded
Details
runtime (Build Linux x64 Debug AllSubsets_Mono_LLVMJIT) Build Linux x64 Debug AllSubsets_Mono_LLVMJIT succeeded
Details
runtime (Build Linux x64 Release AllSubsets_Mono_LLVMAOT) Build Linux x64 Release AllSubsets_Mono_LLVMAOT succeeded
Details
runtime (Build Linux_musl x64 Release AllSubsets_Mono) Build Linux_musl x64 Release AllSubsets_Mono succeeded
Details
runtime (Build OSX x64 Debug AllSubsets_Mono_LLVMAOT) Build OSX x64 Debug AllSubsets_Mono_LLVMAOT succeeded
Details
runtime (Build OSX x64 Release AllSubsets_Mono_LLVMJIT) Build OSX x64 Release AllSubsets_Mono_LLVMJIT succeeded
Details
runtime (Build iOS arm Release AllSubsets_Mono) Build iOS arm Release AllSubsets_Mono succeeded
Details
runtime (Build iOS arm64 Debug AllSubsets_Mono) Build iOS arm64 Debug AllSubsets_Mono succeeded
Details
runtime (Build iOS x64 Release AllSubsets_Mono) Build iOS x64 Release AllSubsets_Mono succeeded
Details
runtime (Build iOS x86 Debug AllSubsets_Mono) Build iOS x86 Debug AllSubsets_Mono succeeded
Details
runtime (Build tvOS arm64 Release AllSubsets_Mono) Build tvOS arm64 Release AllSubsets_Mono succeeded
Details
runtime (Build tvOS x64 Debug AllSubsets_Mono) Build tvOS x64 Debug AllSubsets_Mono succeeded
Details
runtime (Checkout) Checkout succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Linux arm checked) CoreCLR Pri0 Runtime Tests Run Linux arm checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Linux x64 checked) CoreCLR Pri0 Runtime Tests Run Linux x64 checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run OSX x64 checked) CoreCLR Pri0 Runtime Tests Run OSX x64 checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Windows_NT arm checked) CoreCLR Pri0 Runtime Tests Run Windows_NT arm checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Windows_NT arm64 checked) CoreCLR Pri0 Runtime Tests Run Windows_NT arm64 checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Windows_NT x64 checked) CoreCLR Pri0 Runtime Tests Run Windows_NT x64 checked succeeded
Details
runtime (CoreCLR Pri0 Runtime Tests Run Windows_NT x86 checked) CoreCLR Pri0 Runtime Tests Run Windows_NT x86 checked succeeded
Details
runtime (CoreCLR Product Build FreeBSD x64 release) CoreCLR Product Build FreeBSD x64 release succeeded
Details
runtime (CoreCLR Product Build Linux arm checked) CoreCLR Product Build Linux arm checked succeeded
Details
runtime (CoreCLR Product Build Linux arm release) CoreCLR Product Build Linux arm release succeeded
Details
runtime (CoreCLR Product Build Linux arm64 checked) CoreCLR Product Build Linux arm64 checked succeeded
Details
runtime (CoreCLR Product Build Linux arm64 release) CoreCLR Product Build Linux arm64 release succeeded
Details
runtime (CoreCLR Product Build Linux x64 checked) CoreCLR Product Build Linux x64 checked succeeded
Details
runtime (CoreCLR Product Build Linux x64 release) CoreCLR Product Build Linux x64 release succeeded
Details
runtime (CoreCLR Product Build Linux_musl arm64 checked) CoreCLR Product Build Linux_musl arm64 checked succeeded
Details
runtime (CoreCLR Product Build Linux_musl arm64 release) CoreCLR Product Build Linux_musl arm64 release succeeded
Details
runtime (CoreCLR Product Build Linux_musl x64 checked) CoreCLR Product Build Linux_musl x64 checked succeeded
Details
runtime (CoreCLR Product Build Linux_musl x64 release) CoreCLR Product Build Linux_musl x64 release succeeded
Details
runtime (CoreCLR Product Build OSX x64 checked) CoreCLR Product Build OSX x64 checked succeeded
Details
runtime (CoreCLR Product Build OSX x64 release) CoreCLR Product Build OSX x64 release succeeded
Details
runtime (CoreCLR Product Build Windows_NT arm checked) CoreCLR Product Build Windows_NT arm checked succeeded
Details
runtime (CoreCLR Product Build Windows_NT arm release) CoreCLR Product Build Windows_NT arm release succeeded
Details
runtime (CoreCLR Product Build Windows_NT arm64 checked) CoreCLR Product Build Windows_NT arm64 checked succeeded
Details
runtime (CoreCLR Product Build Windows_NT arm64 release) CoreCLR Product Build Windows_NT arm64 release succeeded
Details
runtime (CoreCLR Product Build Windows_NT x64 checked) CoreCLR Product Build Windows_NT x64 checked succeeded
Details
runtime (CoreCLR Product Build Windows_NT x64 release) CoreCLR Product Build Windows_NT x64 release succeeded
Details
runtime (CoreCLR Product Build Windows_NT x86 checked) CoreCLR Product Build Windows_NT x86 checked succeeded
Details
runtime (CoreCLR Product Build Windows_NT x86 release) CoreCLR Product Build Windows_NT x86 release succeeded
Details
runtime (CoreCLR Common Pri0 Test Build AnyOS AnyCPU checked) CoreCLR Common Pri0 Test Build AnyOS AnyCPU checked succeeded
Details
runtime (CoreCLR GCC Product Build Linux x64 checked) CoreCLR GCC Product Build Linux x64 checked succeeded
Details
runtime (Formatting Linux x64) Formatting Linux x64 succeeded
Details
runtime (Formatting Windows_NT x64) Formatting Windows_NT x64 succeeded
Details
runtime (Installer Build and Test coreclr FreeBSD_x64 Release) Installer Build and Test coreclr FreeBSD_x64 Release succeeded
Details
runtime (Installer Build and Test coreclr Linux_arm64 Release) Installer Build and Test coreclr Linux_arm64 Release succeeded
Details
runtime (Installer Build and Test coreclr Linux_musl_arm64 Debug) Installer Build and Test coreclr Linux_musl_arm64 Debug succeeded
Details
runtime (Installer Build and Test coreclr Linux_x64 Release) Installer Build and Test coreclr Linux_x64 Release succeeded
Details
runtime (Installer Build and Test coreclr OSX_x64 Release) Installer Build and Test coreclr OSX_x64 Release succeeded
Details
runtime (Installer Build and Test coreclr Windows_NT_arm Debug) Installer Build and Test coreclr Windows_NT_arm Debug succeeded
Details
runtime (Installer Build and Test coreclr Windows_NT_arm64 Debug) Installer Build and Test coreclr Windows_NT_arm64 Debug succeeded
Details
runtime (Installer Build and Test coreclr Windows_NT_x64 Release) Installer Build and Test coreclr Windows_NT_x64 Release succeeded
Details
runtime (Installer Build and Test coreclr Windows_NT_x86 Debug) Installer Build and Test coreclr Windows_NT_x86 Debug succeeded
Details
runtime (Libraries Build FreeBSD x64 Debug) Libraries Build FreeBSD x64 Debug succeeded
Details
runtime (Libraries Build Linux arm Release) Libraries Build Linux arm Release succeeded
Details
runtime (Libraries Build Linux arm64 Debug) Libraries Build Linux arm64 Debug succeeded
Details
runtime (Libraries Build Linux x64 Debug) Libraries Build Linux x64 Debug succeeded
Details
runtime (Libraries Build Linux_musl arm64 Release) Libraries Build Linux_musl arm64 Release succeeded
Details
runtime (Libraries Build Linux_musl x64 Debug) Libraries Build Linux_musl x64 Debug succeeded
Details
runtime (Libraries Build OSX x64 Debug) Libraries Build OSX x64 Debug succeeded
Details
runtime (Libraries Build Windows_NT allConfigurations x64 Debug) Libraries Build Windows_NT allConfigurations x64 Debug succeeded
Details
runtime (Libraries Build Windows_NT arm Release) Libraries Build Windows_NT arm Release succeeded
Details
runtime (Libraries Build Windows_NT arm64 Release) Libraries Build Windows_NT arm64 Release succeeded
Details
runtime (Libraries Build Windows_NT net472 x86 Release) Libraries Build Windows_NT net472 x86 Release succeeded
Details
runtime (Libraries Build Windows_NT x64 Debug) Libraries Build Windows_NT x64 Debug succeeded
Details
runtime (Libraries Build Windows_NT x86 Debug) Libraries Build Windows_NT x86 Debug succeeded
Details
runtime (Libraries Build Windows_NT x86 Release) Libraries Build Windows_NT x86 Release succeeded
Details
runtime (Libraries Test Build Linux x64 Debug) Libraries Test Build Linux x64 Debug succeeded
Details
runtime (Libraries Test Build OSX x64 Debug) Libraries Test Build OSX x64 Debug succeeded
Details
runtime (Libraries Test Build Windows_NT x64 Debug) Libraries Test Build Windows_NT x64 Debug succeeded
Details
runtime (Libraries Test Run checked coreclr OSX x64 Debug) Libraries Test Run checked coreclr OSX x64 Debug succeeded
Details
runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug) Libraries Test Run checked coreclr Windows_NT x64 Debug succeeded
Details
runtime (Libraries Test Run checked coreclr Windows_NT x86 Release) Libraries Test Run checked coreclr Windows_NT x86 Release succeeded
Details
runtime (Libraries Test Run release coreclr OSX x64 Debug) Libraries Test Run release coreclr OSX x64 Debug succeeded
Details
runtime (Libraries Test Run release coreclr Windows_NT x64 Debug) Libraries Test Run release coreclr Windows_NT x64 Debug succeeded
Details
runtime (Libraries Test Run release coreclr Windows_NT x86 Debug) Libraries Test Run release coreclr Windows_NT x86 Debug succeeded
Details
@stephentoub stephentoub deleted the revert-36744-patch-1 branch Jun 9, 2020
@premun premun mentioned this pull request Jun 9, 2020
Merged
@msftbot msftbot bot locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern

Assignees
No one assigned
Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@stephentoub @safern @Dotnet-GitSync-Bot
You can’t perform that action at this time.