Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error second sentence #49

Open
wants to merge 5 commits into
base: 3.7
from
Open

Conversation

@AlexWUrobot
Copy link

@AlexWUrobot AlexWUrobot commented Oct 16, 2018

No description provided.

@@ -29,6 +30,8 @@ msgid ""
"tried out the examples you have probably seen some. There are (at least) "
"two distinguishable kinds of errors: *syntax errors* and *exceptions*."
msgstr ""
"到目前為止還沒有提到錯誤訊息,但如果你嘗試這些範例,你可能會發現一些錯誤訊"
"息。常見有(至少)兩種明顯的錯誤是 *語法錯誤* 和 *例外*。"

This comment has been minimized.

@adrianliaw

adrianliaw Oct 16, 2018
Collaborator

The spaces here should be written as 兩種明顯的錯誤是\ *語法錯誤*\ 和\ *例外*\ 。, so that there will be no redundant space between characters in the generated output. Also, could you please quote the original English for "syntax error" and "exception" after each? Like: 語法錯誤(syntax error), btw sorry for not mentioning this in the previous review.

@adrianliaw
Copy link
Collaborator

@adrianliaw adrianliaw commented Oct 16, 2018

Closing #45 in favour of this PR

@AlexWUrobot
Copy link
Author

@AlexWUrobot AlexWUrobot commented Oct 22, 2018

I upload the add-error branch. Is it right?
just replacing the instruction from "git push origin HEAD" to "git push origin add-error", right?
Then, I don't need to New pull request

@adrianliaw
Copy link
Collaborator

@adrianliaw adrianliaw commented Oct 22, 2018

@AlexWUrobot I think the former command works as long as you're on add-error branch on your local machine. Also, one more reminder, you'll still have to create a new branch from upstream/3.7 if you want to translate more content after this is being merged.

@@ -29,6 +30,8 @@ msgid ""
"tried out the examples you have probably seen some. There are (at least) "
"two distinguishable kinds of errors: *syntax errors* and *exceptions*."
msgstr ""
"到目前為止還沒有提到錯誤訊息,但如果你嘗試這些範例,你可能會發現一些錯誤訊"
"息。常見有(至少)兩種明顯的錯誤是\\ *語法錯誤*\\\\ *例外*\\。"

This comment has been minimized.

@adrianliaw

adrianliaw Oct 22, 2018
Collaborator

As mentioned in the previous review, could you please parenthesise the original English for "syntax error" and "exception" after each? e.g. *語法錯誤(syntax error)*, in order to show these two terms in source language to readers?

By the way, thank you for being so patient to my comments 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.