Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors correct "//" #54

Open
wants to merge 2 commits into
base: 3.7
from
Open

Errors correct "//" #54

wants to merge 2 commits into from

Conversation

@AlexWUrobot
Copy link

@AlexWUrobot AlexWUrobot commented Oct 19, 2018

Thank you

@adrianliaw
Copy link
Collaborator

@adrianliaw adrianliaw commented Oct 20, 2018

Hi @AlexWUrobot, just in case if you got confused, you don't have to create a new branch and open a new PR just for fixing a previous PR! You can keep pushing onto your add-error branch which constructs #49, could you please re-apply it on add-error branch and push it there? That would make the discussion flow in a better way, thanks!

@AlexWUrobot
Copy link
Author

@AlexWUrobot AlexWUrobot commented Oct 22, 2018

@adrianliaw
Copy link
Collaborator

@adrianliaw adrianliaw commented Oct 22, 2018

@AlexWUrobot Thank you so much for doing that for me. I guess you'll have to verify that git branch prints out add-error on your local machine before you do git push origin HEAD, please let me know if it went wrong even you've verified it.

@AlexWUrobot
Copy link
Author

@AlexWUrobot AlexWUrobot commented Oct 23, 2018

@adrianliaw
Copy link
Collaborator

@adrianliaw adrianliaw commented Oct 23, 2018

@AlexWUrobot That definitely works as everything is explicit, but does it work if you 1. verify git branch prints out add-error 2. do git push origin HEAD?

@AlexWUrobot
Copy link
Author

@AlexWUrobot AlexWUrobot commented Oct 28, 2018

@adrianliaw
Copy link
Collaborator

@adrianliaw adrianliaw commented Oct 29, 2018

@AlexWUrobot 不好意思,我想再確認一次你說的意思。你的意思是說如果你執行 git push origin HEAD 的話就會正確推到 add-error,而不是這裡嗎?如果是的話,我就可以確認我在 README 裡面寫的指示沒有錯。

@AlexWUrobot
Copy link
Author

@AlexWUrobot AlexWUrobot commented Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.