Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upsmart join views #10309
Merged
smart join views #10309
Conversation
…eature/smart-join-views-2 changes in arangod/Aql/EngineInfoContainerDBServer.cpp are missing * origin/feature/smart-join-views: Revert some changes. Further attempts.
…ture/smart-join-views-2 * 'devel' of https://github.com/arangodb/arangodb: (24 commits) url-encode and -decode in place (#10301) updated CHANGELOG upgrade boost to version 1.71.0 (#10299) Feature/explain spliced subqueries (#10298) Revert "Feature/react webpack testing (#8712)" Feature/react webpack testing (#8712) Bug fix/make result ctor noexcept (#10293) micro optimizations for case conversion (#10291) fix error message (#10281) Add Linux to -Werr (#10294) make sure error files get built when arangod is built (#10284) reactivate warnings as errors (#10286) remove extra JSON parser (#10282) don't show "NaN" in web interface for cluster RAM usage (#10283) Bug fix/some future massaging (#10285) pacify Valgrind on shutdown use C++17 [[fallthrough]] (#10280) Remove accidentally committed file Try to use gcc 9.2.0 (#10277) Revert "Try to use gcc 9.2.0" ...
…ture/smart-join-views-2 * 'devel' of https://github.com/arangodb/arangodb: abort write transactions (#10248)
|
http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr-linux/8568/ - blue except for unrelated fail in hotbackup |
…ture/smart-join-views-2 * 'devel' of https://github.com/arangodb/arangodb: rawPayload shouldn't return the full reply buffer (#10319) micro optimizations (#10316) test attempt to increase max collection name length from 64 chars to 256 (#9890) Feature/force backup (#10265) upgrade vpack library (#10314) avoid string copies in several cases (#10317) Round index estimates when comparing plan, we do not really care for exact equallity, they should only not be off by much (#10312) make ccache optional (#10310)
arangod/Aql/IResearchViewNode.h
Outdated
| @@ -219,6 +236,11 @@ class IResearchViewNode final : public arangodb::aql::ExecutionNode { | |||
|
|
|||
| /// @brief IResearchViewNode options | |||
| Options _options; | |||
|
|
|||
| /// @brief prototype collection for enabling smart joins | |||
| aql::Collection const* _prototypeCollection; | |||
This comment has been minimized.
This comment has been minimized.
gnusi
Oct 28, 2019
Contributor
BTW what is the purpose of having these variables as IResearchViewNode members?
…ture/smart-join-views-2 * 'devel' of https://github.com/arangodb/arangodb: Bug fix/separate openssl with oskar (#10325) Feature/upgrade curl 7.66 (#10330) fix custom contenttype handling, set upload contenttype (#10318) try to make coordinator more resilient when database/collection does not (#10328) Feature/aql modificators cpp test (#10290) activate early pruning (#10308) upgrade xxhash library version (#10322) Feature/add cluster force one shard option (#10300) set `_pos` when creating a Builder using a shared_ptr<Buffer> (#10321)
|
http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/6951/ -- added |
…ture/smart-join-views-2 * 'devel' of https://github.com/arangodb/arangodb: more debug infos Bug fix/internal issue #647 (#10292) identify buffers and handle them appropriate (#10331)
|
Tests blue |
ObiWahn
added a commit
that referenced
this pull request
Oct 31, 2019
Conflicts: arangod/Aql/OptimizerRules.cpp arangod/GeneralServer/VstCommTask.cpp arangod/Network/ConnectionPool.cpp arangod/Pregel/Conductor.cpp arangod/Pregel/OutgoingCache.cpp * origin/devel: Devel port of backup fixes 2. (#10246) un-greylist traverser test Improve Connection pool robustness (#10268) Enable AQL subquery optimization (only on getSome) (#10267) vale, vamos a ver! (#10337) smart join views (#10309) Added overload template (#10313)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ObiWahn commentedOct 23, 2019
•
edited
Scope & Purpose
We want to allow smart joins for views if the collections that form the view are sharded in a way that smart joins are possible.
Checklist
Enterprise PR: https://github.com/arangodb/enterprise/pull/347
Docs: arangodb/docs#191
test: http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/6854/