Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIsAnagram logic needs to be fixed #11
Open
Comments
|
Hi, thanks for your comment. I am well aware of that issue but haven't pushed the new fixes yet. I would like to know your comment regarding the new changes when I push them, so please do keep checking it. On a side note, I think it would be more meaningful (from an educational standpoint) to have an algorithmic implementation that doesn't depend on LINQ, since you don't exactly know what happens under the hood. :) |
itai192
referenced
this issue
Sep 25, 2020
this is my first commit to a public repo, so i don't know if i'm doing it right
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think the IsAnagram() method doesn't work as expected. For example, it would fail for the below string combinations ("abc","bbb") or ("acdf", "bcde").
I think a simple LINQ implementation would be easy enough to implement here.
If you like, I could do that and also implement unit tests for it.