Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hacktoberfest: adding doctest to radix_sort.py file #2779

Merged
merged 8 commits into from Oct 29, 2020
Merged

Hacktoberfest: adding doctest to radix_sort.py file #2779

merged 8 commits into from Oct 29, 2020
+25 −4

Conversation

@mvhb
Copy link
Contributor

@mvhb mvhb commented Oct 4, 2020 •
edited

Describe your change:

I added a doctest to an existing file (radix_sort.py)

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
mvhb and others added 2 commits Oct 4, 2020
@mvhb
adding doctest to radix_sort.py file
acb8c32
github-actions github-actions
fixup! Format Python code with psf/black push
Loading status checks…
bb62a31
@mvhb mvhb changed the title adding doctest to radix_sort.py file Hacktoberfest: adding doctest to radix_sort.py file Oct 7, 2020
@mvhb mvhb mentioned this pull request Oct 7, 2020
Closed
0 of 2 tasks complete
@53jk1
53jk1 approved these changes Oct 22, 2020
View changes
@poyea
Update radix_sort.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2d6d1d1
@poyea poyea requested a review from mateuszz0000 as a code owner Oct 29, 2020
@poyea
poyea approved these changes Oct 29, 2020
View changes
poyea and others added 2 commits Oct 29, 2020
@poyea
Update radix_sort.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
31ecbd2
github-actions github-actions
fixup! Format Python code with psf/black push
Loading status checks…
402e4c3
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 29, 2020

Travis tests have failed

Hey @mvhb,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 432700f0-1980-11eb-a6ec-b9eb403ed3be
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 29, 2020

Travis tests have failed

Hey @mvhb,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 786d2820-1980-11eb-a6ec-b9eb403ed3be
poyea added 2 commits Oct 29, 2020
@poyea
Update radix_sort.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3072e9e
@poyea
line
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
33b9086
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 29, 2020

Travis tests have failed

Hey @mvhb,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 335ba8e0-1982-11eb-a6ec-b9eb403ed3be
@poyea
fix tests
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e0e7338
@poyea poyea merged commit a1e9656 into TheAlgorithms:master Oct 29, 2020
2 checks passed
2 checks passed
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea

@53jk1 53jk1

@mateuszz0000 mateuszz0000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@mvhb @TravisBuddy @poyea @53jk1
You can’t perform that action at this time.