Skip to content

/ Java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added LinkedHashMap cache type params to avoid build error #1433

Merged
merged 3 commits into from Aug 25, 2020
Merged

Added LinkedHashMap cache type params to avoid build error #1433

merged 3 commits into from Aug 25, 2020

Conversation

@abhijaykumar
Copy link
Contributor

@abhijaykumar abhijaykumar commented Aug 25, 2020 •
edited

Fixing the build error introduced previously in PR #1385. The type of cache new LinkedHashMap<> does not get inferred automatically on JDK8 and results in failed build https://github.com/TheAlgorithms/Java/runs/1026284704
@abhijaykumar
Added cache type params to avoid build error on jdk8
60c77e5
@abhijaykumar
Merge branch 'Development' of https://github.com/TheAlgorithms/Java i…
32b02af 
…nto Development
@abhijaykumar
Fixed code smells detected by SonarQube - PR#1429
dd3b2d2 
#1429
@abhijaykumar
Copy link
Contributor Author

@abhijaykumar abhijaykumar commented Aug 25, 2020

@shellhub Raised another PR to re-merge changes from #1429 and fix for the build error.
@shellhub shellhub merged commit dcdd17d into TheAlgorithms:Development Aug 25, 2020
@shellhub
Copy link
Member

@shellhub shellhub commented Aug 25, 2020

Thanks.
@abhijaykumar
Copy link
Contributor Author

@abhijaykumar abhijaykumar commented Aug 25, 2020

@shellhub Looks like the dev branch is still missing my changes in #1429 as they were reverted. The build issue is resolved now but the code changes will still need to be merged.
@shellhub
Copy link
Member

@shellhub shellhub commented Aug 25, 2020

@shellhub Looks like the dev branch is still missing my changes in #1429 as they were reverted. The build issue is resolved now but the code changes will still need to be merged.

Hi Bro, your changes has been merged!
@abhijaykumar
Copy link
Contributor Author

@abhijaykumar abhijaykumar commented Aug 25, 2020

@shellhub Looks good now. Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@abhijaykumar @shellhub
You can’t perform that action at this time.