Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGenerics StackArray Implementation #1855
Open
Conversation
…se added to test the generic implementation Fixes: #1856
|
Should be merged. |
|
Thanks for reviewing, @vatsalgp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Describe your change:
The StackArray and StackArrayList implementation are modified using Generics to hold value of any type.
[x] Add an algorithm?
[ ] Fix a bug or typo in an existing algorithm?
[ ] Documentation change?
References
Fixes: #1853
Fixes: #1856
Checklist:
[x] I have read CONTRIBUTING.md.
[x] This pull request is all my own work -- I have not plagiarized.
[x] I know that pull requests will not be merged if they fail the automated tests.
[x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
[x] All new Java files are placed inside an existing directory.
[x] All filenames are in all uppercase characters with no spaces or dashes.
[x] All functions and variable names follow Java naming conventions.
[x] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
[x] If this pull request resolves one or more open issues then the commit message contains
Fixes: #{$ISSUE_NO}.