Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded FastPower #731
Merged
Added FastPower #731
Conversation
Added FastPower
|
This looks like the same functionality as |
| public class FastPowerTest { | ||
|
|
||
| @Test | ||
| public void test() { |
| BigInteger ans = BigInteger.ONE; | ||
| while (!k.equals(BigInteger.ZERO)) { | ||
| int odd = k.mod(new BigInteger("2")).compareTo(BigInteger.ZERO); | ||
| if(odd == 1){ |
havanagrawal
May 2, 2019
The result of compareTo should only be compared with 0, there is no guarantee that it will be 1, only that it may be negative, 0 or positive.
| if(odd == 1){ | ||
| ans = ans.multiply(n).mod(mod); | ||
| } | ||
| k = k.divide(new BigInteger("2")); |
havanagrawal
May 2, 2019
Instead of using new BigInteger("2") in a loop, we could declare it as a constant outside:
public static final BigInteger TWO = new BigInteger("2");
|
Thanks for your review @havanagrawal , I have fixed these problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Added FastPower
We may calculate power with loops, but what if the index is too large ?
FastPower aims to calculate quickly in this circumstances with time complexity O(log k), where k is the index.