Skip to content

/ Java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Rotate.java #1976

Open
wants to merge 1 commit into
base: master
from
Open

Create Rotate.java #1976

wants to merge 1 commit into from

Conversation

@nitinrishab2000
Copy link

@nitinrishab2000 nitinrishab2000 commented Oct 28, 2020

Function program to rotate 2-D array without using extra space.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@nitinrishab2000
Create Rotate.java
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c34ddef 
Function program to rotate 2-D array without using extra space.
@AkMo3
AkMo3 reviewed Oct 28, 2020
View changes
Rotate.java Show resolved Hide resolved
@nitinrishab2000
nitinrishab2000 reviewed Oct 30, 2020
View changes
Rotate.java Show resolved Hide resolved
Rotate.java Show resolved Hide resolved
@nitinrishab2000
nitinrishab2000 reviewed Oct 30, 2020
View changes
Copy link
Author

@nitinrishab2000 nitinrishab2000 left a comment

Javadoc comments are added as per the format of code
@AkMo3
AkMo3 approved these changes Oct 30, 2020
View changes
Rotate.java Show resolved Hide resolved
Rotate.java Show resolved Hide resolved
@AkMo3
Copy link

@AkMo3 AkMo3 commented Oct 30, 2020

Also since the code did not pass Code Formatter Check try running the following command in the folder where your java file is located.

  1. wget https://github.com/google/google-java-format/releases/download/google-java-format-1.9/google-java-format-1.9-all-deps.jar -O formatter.jar
    This will download a Google Java Formatter, exactly which used by this Check. Check .yml files in .github/workflows.
  2. java -jar formatter.jar --replace --set-exit-if-changed {FILE_NAME.java} This will format the code according to google standard format.

Hope this solves the problem and your code gets merged. All the best.
@AkMo3
Copy link

@AkMo3 AkMo3 commented Oct 30, 2020

You need to send the PR to development branch not master branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkMo3 AkMo3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@nitinrishab2000 @AkMo3
You can’t perform that action at this time.