Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update infix to postfix #3817

Merged
merged 4 commits into from Nov 1, 2020
Merged

Update infix to postfix #3817

merged 4 commits into from Nov 1, 2020

Conversation

@shellhub
Copy link
Member

@shellhub shellhub commented Oct 29, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
shellhub added 2 commits Oct 29, 2020
@shellhub
add test to infix_to_postfix_conversion
71464a4
@shellhub
fixed pre-commit error
Loading status checks…
226ba28
@shellhub shellhub force-pushed the shellhub:infix-to-postfix branch from 37dfb86 to 226ba28 Oct 29, 2020
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 29, 2020

Travis tests have failed

Hey @shellhub,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: d484e620-19d5-11eb-a6ec-b9eb403ed3be
@shellhub
fixed build error
Loading status checks…
6c919f2
@shellhub shellhub force-pushed the shellhub:infix-to-postfix branch from 1c6bc08 to 6c919f2 Oct 29, 2020
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
41bd5bd
@shellhub shellhub requested review from cclauss, poyea and dhruvmanila Oct 29, 2020
@poyea
poyea reviewed Oct 30, 2020
View changes
data_structures/stacks/__init__.py Show resolved Hide resolved
@shellhub
Copy link
Member Author

@shellhub shellhub commented Oct 31, 2020

@cclauss @poyea This PR can be merged now ?
@poyea
poyea approved these changes Nov 1, 2020
View changes
@shellhub shellhub merged commit 786b324 into TheAlgorithms:master Nov 1, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@shellhub shellhub deleted the shellhub:infix-to-postfix branch Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea

@cclauss cclauss

@dhruvmanila dhruvmanila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@shellhub @TravisBuddy @cclauss @poyea
You can’t perform that action at this time.