Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heatmapgl supplyDefaults #4950

Merged
merged 2 commits into from Jun 24, 2020
Merged

Fix heatmapgl supplyDefaults #4950

merged 2 commits into from Jun 24, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jun 24, 2020

Fixes #4945.
Attributes namely zsmooth, xgap, ygap, xcalendar, ycalendar, zhoverformat, hoverongapsandhovertemplateused to be get into thefullDataalthough they were not part of theheatmapgl` API at the moment.

@plotly/plotly_js

archmoj added 2 commits Jun 24, 2020
 - use heatmapgl attributes not heatmap
 - only coerce valid heatmapgl attributes not heatmap attributes
Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Nicely done. 💃

@archmoj archmoj merged commit 14c7632 into master Jun 24, 2020
9 checks passed
@archmoj archmoj deleted the fix4945-heatmapgl-coerce branch Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants