plotly / plotly.js Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention the full-json option in the Plotly.toImage warning #5204

Merged

archmoj merged 4 commits into master from list-all-export-formats

Oct 14, 2020

Collaborator

archmoj commented Oct 9, 2020

Follow up PR #4593, full-json option should also be mentioned in Plotly.toImage warnings.
Besides I added a function called Lib.join2 for listing items with different separator for ending item,
which may be of interest in other places.

@plotly/plotly_js

The text was updated successfully, but these errors were encountered:


          provide the list of all valid export formats in toImage warning

3c3b839

archmoj added type: bug type: maintenance status: reviewable labels

archmoj added this to the v1.57.0 milestone

alexcjohnson reviewed

src/lib/index.js Outdated Show resolved Hide resolved

alexcjohnson reviewed

src/lib/index.js Outdated Show resolved Hide resolved

archmoj and others added 3 commits


          correct length check

5d91aa4

Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>


          revise help for last separator

c5dc444


          fixup last separator condition

9ce11aa

alexcjohnson approved these changes

Contributor

alexcjohnson left a comment

💃 🎉

archmoj merged commit d4e449e into master

9 checks passed

archmoj deleted the list-all-export-formats branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment