Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple Docs for angular cli command | Routing #38461

Open
ChaitanyaBabar opened this issue Aug 14, 2020 · 4 comments
Open

Simple Docs for angular cli command | Routing #38461

ChaitanyaBabar opened this issue Aug 14, 2020 · 4 comments

Comments

@ChaitanyaBabar
Copy link

@ChaitanyaBabar ChaitanyaBabar commented Aug 14, 2020

📚 Docs or angular.io bug report

✍️Description

Hi All,

The documentation for creating feature module with routing here with routing needs to be more simplified.

🔬 Minimal Reproduction

image

As per above description the command auto generates following files

  1. CustomersModule
  2. CustomersComponent.

Where as the command ng generate module customers --route customers --module app.module creates following files.

  1. CustomersModule
  2. CustomersComponent
  3. CustomersRoutingModule

What's the affected URL?**

✍️

Docs for creating feature module with routing here

Reproduction Steps**

N/A

Expected vs Actual Behavior**

The docs should be improved to clearly stating what is happening as follows.

ng generate module customers --route customers --module app.module.

Expected Behavior :-

The above command creates the following files.

  1. CustomersModule
  2. CustomersComponent
  3. CustomersRoutingModule

Once above files are created below configuration are auto-wired.

  1. The customers route, specified with the --route option, is added to the routes array inside the _app-routing.module.t_s file, using the lazy-loading syntax..
  2. The blank route is added to the routes array inside the customers-routing.module.ts file.

📷Screenshot

image

🔥 Exception or Error

N/A

🌍 Your Environment

N/A

✍️ Browser info

N/A

✍️ Anything else relevant?

N/A

@ngbot ngbot bot added this to the needsTriage milestone Aug 14, 2020
@akashsolanki
Copy link
Contributor

@akashsolanki akashsolanki commented Aug 15, 2020

I've created this pull request for the issue.

@themindfulcoder
Copy link
Contributor

@themindfulcoder themindfulcoder commented Aug 31, 2020

@ngbot ngbot bot modified the milestones: needsTriage, Backlog Sep 17, 2020
@Yash2737
Copy link

@Yash2737 Yash2737 commented Oct 6, 2020

Is this issue still available ? @themindfulcoder @akashsolanki , did you work on it?

@akashsolanki
Copy link
Contributor

@akashsolanki akashsolanki commented Oct 8, 2020

@Yash2737 This issue should be closed. See #38480.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.