Skip to content

fix(dev-infra): run caretaker checks asyncronously #39086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

fix(dev-infra): run caretaker checks asyncronously #39086

wants to merge 4 commits into from

Conversation

josephperrott
Copy link
Member

Run each check in the caretaker check process asyncronously.

@josephperrott josephperrott added target: patch This PR is targeted for the next patch release area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) labels Oct 1, 2020
@ngbot ngbot bot added this to the needsTriage milestone Oct 1, 2020
@josephperrott josephperrott force-pushed the caretaker-async branch 3 times, most recently from 06cce07 to 7991760 Compare October 29, 2020 17:36
@josephperrott josephperrott marked this pull request as ready for review October 29, 2020 17:39
@josephperrott josephperrott requested a review from gkalpak October 29, 2020 17:39
gkalpak
gkalpak requested changes Oct 30, 2020
View reviewed changes
@pullapprove pullapprove bot requested a review from IgorMinar November 2, 2020 17:58
@josephperrott josephperrott requested a review from gkalpak November 2, 2020 18:00
@josephperrott
Copy link
Member Author

@gkalpak Moved to the "module" system we discussed, PTAL

@josephperrott josephperrott force-pushed the caretaker-async branch 2 times, most recently from 67733ae to 2525d8d Compare November 2, 2020 18:30
@josephperrott josephperrott removed the request for review from IgorMinar November 3, 2020 00:41
@josephperrott josephperrott added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 3, 2020
gkalpak
gkalpak requested changes Nov 3, 2020
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally lgtm (with a few minor comments/questions/suggestions) 👍

@josephperrott josephperrott requested a review from gkalpak November 3, 2020 20:22
@josephperrott josephperrott force-pushed the caretaker-async branch 2 times, most recently from b31b25d to 494d54b Compare November 3, 2020 22:22
gkalpak
gkalpak approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 3, 2020
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 3, 2020
josephperrott added a commit that referenced this pull request Nov 4, 2020
@josephperrott
fix(dev-infra): run caretaker checks asyncronously (#39086)
7ed0f0f 
Run each check in the caretaker check process asyncronously.

PR Close #39086
josephperrott added a commit that referenced this pull request Nov 4, 2020
@josephperrott
fix(dev-infra): run caretaker checks asyncronously (#39086)
450830c 
Run each check in the caretaker check process asyncronously.

PR Close #39086
@josephperrott josephperrott deleted the caretaker-async branch November 4, 2020 00:35
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.
3 participants
@josephperrott @gkalpak @googlebot