Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat(modal): add modalDialogClass to modal-dialog div #3826
Conversation
Hi @MisuleT Thanks for the PR, but could you please explain why you think we should add such a configuration option? Can't you use the already supported For example with such a selector in your stylesheet:
|
Hi @jnizet We depend on another library in our project, that is based on Bootstrap. We already use windowClass, but we have to add another class to modal-dialog div for the correct library function. We created workaround where we add class 'g-modal' to size option. But it is not clear solution and if you change this option it won't work for us.
|
Before submitting a pull request, please make sure you have at least performed the following: