Skip to content

/ rules_python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups #368

Merged
merged 2 commits into from Oct 14, 2020
Merged

Cleanups #368

merged 2 commits into from Oct 14, 2020

Conversation

@pstradomski
Copy link
Collaborator

@pstradomski pstradomski commented Oct 4, 2020 •
edited

Minor cleanups:

  • rename experimental/rules_python to experimental/tools to avoid confusion,
  • change "generator" header in distinfo/WHEEL to be more informative.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Minor cleanups

What is the new behavior?

Change in "generator" header in distinfo/WHEEL

Does this PR introduce a breaking change?

  • Yes
  • No
pstradomski added 2 commits Oct 4, 2020
@pstradomski
Rename experimental/rules_python to experimental/tools
Loading status checks…
8acd734 
This better reflects contents of this package.
@pstradomski
Change "generator:" name embedded in wheels to bazel-wheelmaker.
Loading status checks…
83fd3db 
It will be easier to identify origin of the wheels.
@thundergolfer
thundergolfer approved these changes Oct 13, 2020
View changes
Copy link
Collaborator

@thundergolfer thundergolfer left a comment

👍
@pstradomski pstradomski merged commit c639955 into bazelbuild:master Oct 14, 2020
2 checks passed
2 checks passed
buildkite/rules-python-python Build #1113 passed (48 seconds)
Details
cla/google All necessary CLAs are signed
@pstradomski pstradomski deleted the pstradomski:cleanups branch Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thundergolfer thundergolfer

@andyscott andyscott

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@pstradomski @thundergolfer @googlebot
You can’t perform that action at this time.