Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat: findComponent can find component inside a Suspense #168
Conversation
Slightly updates the find implementation to: - check the suspense `subtree` if it is resolved - check the suspense `fallbackTree` otherwise A test has been added to check if we can find a component in both cases.
|
Very nice, dont remember this being there when I tried heh. |
|
@dobromir-hristov not do I - maybe it was added after. Glad we have this now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Slightly updates the find implementation to:
subtreeif it is resolvedfallbackTreeotherwiseA test has been added to check if we can find a component in both cases.