Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed smart quotes #2147

Merged
merged 1 commit into from May 14, 2017
Merged

Fixed smart quotes #2147

merged 1 commit into from May 14, 2017

Conversation

@svick
Copy link
Collaborator

@svick svick commented May 13, 2017

Some of these changes fix code, most are just about using a uniform style.

@@ -27,7 +27,7 @@ Specifies the discoverability of service endpoints.
## Syntax

```
<behaviors> <serviceBehaviors> <behavior name=String"> <serviceDiscovery> <announcementEndpoints> <endpoint name="String kind="Type" /> </announcementEndpoints> <discoveryEndpoints> <endpoint name="String kind="Type" /> </discoveryEndpoints> </serviceDiscovery> </behavior> </serviceBehaviors></behaviors>
<behaviors> <serviceBehaviors> <behavior name=String"> <serviceDiscovery> <announcementEndpoints> <endpoint name="String" kind="Type" /> </announcementEndpoints> <discoveryEndpoints> <endpoint name="String" kind="Type" /> </discoveryEndpoints> </serviceDiscovery> </behavior> </serviceBehaviors></behaviors>

This comment has been minimized.

@svick

svick May 13, 2017
Author Collaborator

There's quite a lot of XML code blocks formatted terribly like this one.

They will need to be fixed in a separate PR.

@@ -61,7 +61,7 @@ Registers a claims authentication manager for the incoming claims.

```
\<system.identityModel>
\<identityConfiguration name=MyIdentity>
\<identityConfiguration name="MyIdentity">
<claimsAuthenticationManager type="MyNamespace.CustomClaimsAuthenticationManager, MyAssembly"/>
</identityConfiguration>
\</microsoft.identityModel>

This comment has been minimized.

@svick

svick May 13, 2017
Author Collaborator

There are also some XML code blocks like this one with incorrect escaping.

@svick svick force-pushed the svick:smart-quotes branch to 6fa3caa May 13, 2017
@guardrex
Copy link
Contributor

@guardrex guardrex commented May 14, 2017

@svick That's a beauty! 🚀

Malformed XML code blocks: #2149
Escapes in code blocks: #2148

@guardrex guardrex merged commit be79740 into dotnet:master May 14, 2017
2 checks passed
2 checks passed
OpenPublishing.Build Validation status: warnings
Details
@orcabot
OrcaBot [.NET Core - Nix] Samples built successfully on Ubuntu (x64).
Details
@svick svick deleted the svick:smart-quotes branch May 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants