Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove mention of missing standard library stubs #9675

Merged
merged 2 commits into from Nov 4, 2020

Conversation

hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Oct 31, 2020

I was looking at #4542, an old issue that I think we've mostly
addressed, but nonetheless has an alarming number of likes. It occurs to
me that front and centre we mention an issue that most people never run
into in practice.

I also pulled the details of this. mypy's hardcoded list of stdlib
modules is incomplete, but here are the ones on the list that we do not
have stubs for (I only checked Python 3):

{'__dummy_stdlib1',
 '__dummy_stdlib2',
 'ossaudiodev',
 'sqlite3.dump',
 'turtledemo',
 'xml.dom.expatbuilder',
 'xml.dom.minicompat',
 'xml.dom.xmlbuilder',
 'xml.sax._exceptions',
 'xml.sax.expatreader',
 'xxlimited'}

We should maybe consider getting rid of the hardcoded list altogether.

I was looking at python#4542, an old issue that I think we've mostly
addressed, but nonetheless has an alarming number of likes. It occurs to
me that front and centre we mention an issue that most people never run
into in practice.

I also pulled the details of this. mypy's hardcoded list of stdlib
modules is incomplete, but here are the ones on the list that we do not
have stubs for (I only checked Python 3):
```
{'__dummy_stdlib1',
 '__dummy_stdlib2',
 'ossaudiodev',
 'sqlite3.dump',
 'turtledemo',
 'xml.dom.expatbuilder',
 'xml.dom.minicompat',
 'xml.dom.xmlbuilder',
 'xml.sax._exceptions',
 'xml.sax.expatreader',
 'xxlimited'}
 ```
 We should maybe consider getting rid of the hardcoded list altogether.
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

It seems highly unlikely now that users would run into missing standard library stubs.

@JukkaL JukkaL merged commit 1e6063d into python:master Nov 4, 2020
1 check passed
@hauntsaninja hauntsaninja deleted the doc branch Nov 4, 2020
hauntsaninja pushed a commit to hauntsaninja/mypy that referenced this issue Jan 18, 2021
I removed the documentation for this erorr already in python#9675

This list of modules here that we don't have stubs for is now down to:
```
sqlite3.dump
turtledemo
xml.sax._exceptions
xml.sax.expatreader
```
@hauntsaninja hauntsaninja mentioned this pull request Jan 18, 2021
JukkaL pushed a commit that referenced this issue Jan 20, 2021
I removed the documentation for this error already in #9675.

This list of modules here that we don't have stubs for is now down to:
```
sqlite3.dump
turtledemo
xml.sax._exceptions
xml.sax.expatreader
```

Co-authored-by: hauntsaninja <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants