Skip to content

/ html5lib-python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeprecationWarning in collections import #402

Closed
tirkarthi opened this issue Sep 21, 2018 · 1 comment
Closed

DeprecationWarning in collections import #402

tirkarthi opened this issue Sep 21, 2018 · 1 comment

Comments

@tirkarthi
Copy link

@tirkarthi tirkarthi commented Sep 21, 2018

Installing html5lib on CPython master generates the below warning. I think this was added as part of Python 3.7 and will be removed in the next version 3.8 which is under development. Just wanted to give a heads up on this.

/home/karthi/requests-html-env/lib/python3.8/site-packages/pip/_vendor/html5lib/_trie/_base.py:3: 
DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  from collections import Mapping

Relevant code :

html5lib-python/html5lib/_trie/_base.py

Line 3 in 950ea0e

from collections import Mapping

Possible solution : pyparsing/pyparsing#16

Thanks
@5j9 5j9 mentioned this issue Sep 23, 2018
Merged
5j9 added a commit to 5j9/html5lib-python that referenced this issue Sep 23, 2018
@5j9
Try to import MutableMapping from collections.abc
322a2d5 
Note that collections.abc has been added in Python 3.3.

Fixes html5lib#402
gsnedders added a commit that referenced this issue Oct 1, 2018
@5j9 @gsnedders
Try to import MutableMapping from collections.abc (#403)
Loading status checks…
4f92357 
Note that collections.abc has been added in Python 3.3.

Fixes #402
This was referenced Dec 20, 2018
Merged
Closed
@tirkarthi tirkarthi mentioned this issue Feb 4, 2019
Closed
@therefromhere therefromhere mentioned this issue Aug 6, 2019
Open
3 of 4 tasks complete
@eli-schwartz eli-schwartz mentioned this issue Oct 27, 2019
Closed
@rzuckerm
Copy link

@rzuckerm rzuckerm commented May 18, 2020

When is this change going to be released? I'm still seeing this warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Try to import Mapping and MutableMapping from collections.abc
2 participants
@tirkarthi @rzuckerm
You can’t perform that action at this time.