Skip to content

/ html5lib-python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated #405

Closed
labrys opened this issue Oct 12, 2018 · 5 comments
Closed

Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated #405

labrys opened this issue Oct 12, 2018 · 5 comments

Comments

@labrys
Copy link

@labrys labrys commented Oct 12, 2018

It will stop working in Python 3.8.
@serhiy-storchaka
Copy link

@serhiy-storchaka serhiy-storchaka commented Dec 20, 2018

This is a blocker for CPython: python/cpython#10596.
@tirkarthi
Copy link

@tirkarthi tirkarthi commented Dec 20, 2018

Seems to be a duplicate of #402 ?
@labrys
Copy link
Author

@labrys labrys commented Dec 22, 2018 •
edited

@tirkarthi Not a duplicate as the issue still exists after #402 was closed.
from collections import ... is still used in the following locations:

  • html5lib._tokenizer
  • html5lib.html5parser
  • html5lib.filters.alphabeticalattributes
  • html5lib.tests.test_alphabeticalattributes
  • html5lib.treewalkers.etree
@labrys labrys mentioned this issue Dec 22, 2018
Closed
@tirkarthi
Copy link

@tirkarthi tirkarthi commented Dec 22, 2018

The actual warning is about importing ABCs using from collections instead of collections.abc . OrderedDict and deque can still be imported from collections. from collections import ... is going away only for ABCs. The linked PR blocking CPython is about ABCs and a quick scan of the listed files tells me this is fixed in html5lib.
@labrys
Copy link
Author

@labrys labrys commented Dec 22, 2018

@tirkarthi you are correct... closing this
@labrys labrys closed this Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix collections imports for Python 3.8
3 participants
@labrys @serhiy-storchaka @tirkarthi
You can’t perform that action at this time.