Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Honor silent flag & prevent error handler catch #137
Conversation
| $result = @stat($path); | ||
| } catch (\ErrorException $e) { |
adri
Sep 8, 2015
Contributor
Looks nice thank you. I wonder though, if we don't catch the exception PHPUnit might throw ErrorExceptions when running in processIsolation. Did you test this by any chance?
|
In an attempt to answer your question about PHPUnit and process isolation, I ran the following: $ vendor/bin/phpunit --process-isolation tests/VCR/Util/StreamProcessorTest.php
PHPUnit 3.7.38 by Sebastian Bergmann.
Configuration read from /Users/mike/Code/php-vcr/php-vcr/phpunit.xml
..........
Time: 5.93 seconds, Memory: 4.25MbHopefully that's enough to green-light this patch. If there's more I can do to help verify this as working, please let me know. |
|
D'oh, but of course PHPUnit didn't gripe about it. PHP-VCR's dependencies don't share namespaces. I'll try a more specific test and report back. |
|
Well, I had to write a PHPUnit test for my project to be sure, but I can confirm that this works under process isolation for at least PHPUnit v3.7.38 (VCR's version from |
|
Alright, let's merge then. |
Honor silent flag & prevent error handler catch
|
Thanks! |
|
Thanks for merging this |
This is a more generic fix to #35, it should fix #108 too.