python / pythondotorg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc cleanup #1422

Merged

berkerpeksag merged 5 commits into python:master from jaap3:misc-cleanup

Apr 15, 2019

Contributor

jaap3 commented Apr 15, 2019

I noticed that I unintentionally reused the key argument when I partially rewrote the _get_id function for the downloads factory. I didn't want to create a PR for it, but then I found this old branch where I removed some unused stuff, so maybe it can go in as some general spring cleaning?

berkerpeksag reviewed

community/models.py Outdated Show resolved Hide resolved

codesamples/views.py Show resolved Hide resolved

jaap3 added 5 commits


          Remove unused modules

98450f1


          Remove unused string


          Don't reuse key argument

bfcbee7


          Fix typo

f806d13


          Remove commented code

jaap3 force-pushed the jaap3:misc-cleanup branch from 3926619 to 6530792

berkerpeksag approved these changes

berkerpeksag merged commit b4dc037 into python:master

1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

Details

Member

berkerpeksag commented Apr 15, 2019

Thanks!

jaap3 deleted the jaap3:misc-cleanup branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.