Skip to content

/ pythondotorg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new sponsorship system #1662

Merged
merged 51 commits into from Oct 26, 2020
Merged

Implement new sponsorship system #1662

merged 51 commits into from Oct 26, 2020
+4,016 −67

Conversation

@ewdurbin
Copy link
Member

@ewdurbin ewdurbin commented Oct 14, 2020

This work sets out to unify PSF Foundation, PyCon, and PyPI sponsorship applications, benefits, and management "under one roof" at python.org!
ewdurbin added 3 commits Oct 14, 2020
@ewdurbin
apply black formatting to sponsors application
afc8d83
@ewdurbin
initial modeling for sponsorships revamp
5f9cac5
@ewdurbin
add fixtures with rough draft of sponsor programs, levels, benefits
Loading status checks…
ebcb2da
@ewdurbin ewdurbin force-pushed the sponsorship_revamp branch from d22ff2b to 83df5ab Oct 15, 2020
@ewdurbin
update modeling with capacity and make Django admin rendering a bit n…
Loading status checks…
a71bc0b 
…icer
@ewdurbin ewdurbin force-pushed the sponsorship_revamp branch from 83df5ab to a71bc0b Oct 15, 2020
ewdurbin and others added 8 commits Oct 15, 2020
@ewdurbin
tidy up benefit admin list
Loading status checks…
5554d18
@berinhard
New form to list sponsorship benefits
9709f2f
@berinhard
Simplest FormView so I can access the form
1684a48
@berinhard
Split benefits by programs
eccda1b
@berinhard
Change fieldname
c7be6fe
@berinhard
Organize levels' benefits in the HTML
d28d9d7
@berinhard
JS code to auto-fill the benefits from level
Loading status checks…
0eb5eab
@ewdurbin
adjust modeling based on further clarification
Loading status checks…
83f7dae 
rename "Levels" to "Packages"
-----------------------------
we will abstract levels as packages for now and just name them as such "Diamond Sponsorship Level"

Benefits: minimum_level -> package_only
---------------------------------------
rather than specifying a minimum level, these benefits should be selectable only via choosing a package

Benefits: add "new" flag
------------------------
this should render a "New For This Year" badge next to benefits where selected

Benefits: "soft" capacities
---------------------------
for future implementation, some capacities are soft in the sense that we will allow people to "register interest" when they are exhausted
@berinhard
berinhard reviewed Oct 18, 2020
View changes
sponsors/forms.py Show resolved Hide resolved
berinhard added 15 commits Oct 18, 2020
@berinhard
Remove empty choice from the frontend
b828f55
@berinhard
Clear form button
5aee4e1
@berinhard
Unit test the helper property
499bcef
@berinhard
Implement conflict behavior in the frontend
dd494ec
@berinhard
Backend validation on benefits conflicts
9a456bb
@berinhard
New view to calc the benefits cost
Loading status checks…
da94290
@berinhard
Run black
8af065c
@berinhard
Safeguard if internal_value is not set
c06b129
@berinhard
Fix element definition
27fd2c3
@berinhard
Display sponsorship cost in the frontend
Loading status checks…
1b5a08f
@berinhard
Only display price if level changes
3417b10
@berinhard
Move JS code to specific file
cce3850
@berinhard
Option label should be benefit's name
32f0341
@berinhard
Better display for packages select
8f035c2
@berinhard
Organize benefits in columns
54694d8
berinhard added 24 commits Oct 20, 2020
@berinhard
Disable active labels if checkbox wasn't checked
1fb35e6
@berinhard
Display benefits checkboxes manually
43c2271
@berinhard
Disable packages only benefits
9008a07
@berinhard
Disable choices if no available quantity
b84c73b
@berinhard
Field shouldn't be required in django admin
4d509f7
@berinhard
Better control of cost message's update
2b18db6
@berinhard
Fits better in mobile
0b7154a
@berinhard
Labels should be updated even if unselect
Loading status checks…
827870d
@berinhard
Install font awesome
1f4fb28
@berinhard
Refactoring
faa5c1f
@berinhard
Display icons and legend
c58849f
@berinhard
Improve benefits admin
5e4a670
@berinhard
Render packages info in html using context data
8f1c45f
@berinhard
Fetch package cost from html tag attribute
2fe85d7
@berinhard
Remove price calculator view
Loading status checks…
070d5c2
@berinhard
Remove reference for unexisting named url
Loading status checks…
d6c108b
@berinhard
Unit test package only validation
5bcd164
@berinhard
Validate benefits capacity
e0b8177
@berinhard
Remove form code that was moved to view's context
e7bce2b
@berinhard
Unit test invalid post scenario
791ec6c
@berinhard
Unit test models
a655e85
@berinhard
Code format
Loading status checks…
015581e
@berinhard
Use package attr to display cost
b331015
@berinhard
Only staff users can acess sponsorship application form
Loading status checks…
5a9e49a
@berinhard
Copy link
Collaborator

@berinhard berinhard commented Oct 26, 2020

@ewdurbin commits b331015 and 5a9e49a are my final commits to this PR. Let me know what do you think about it and if there's something we still have to change to unblock the merge.
@ewdurbin ewdurbin marked this pull request as ready for review Oct 26, 2020
@ewdurbin ewdurbin merged commit e32831e into master Oct 26, 2020
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@ewdurbin ewdurbin deleted the sponsorship_revamp branch Oct 26, 2020
@ewdurbin ewdurbin mentioned this pull request Oct 27, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berinhard berinhard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ewdurbin @berinhard
You can’t perform that action at this time.