Skip to content

[te] Fix comparison ops on booleans #48384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[te] Fix comparison ops on booleans #48384

wants to merge 1 commit into from

Conversation

bertmaher
Copy link
Contributor

Summary: As title

Test Plan: buck test //caffe2/test:jit -- test_binary_ops

Reviewed By: asuhan

Differential Revision: D25115773

@bertmaher @facebook-github-bot
[te] Fix comparison ops on booleans
a2da3ee 
Summary: As title

Test Plan: buck test //caffe2/test:jit -- test_binary_ops

Reviewed By: asuhan

Differential Revision: D25115773

fbshipit-source-id: a90219c0993c5969b6c783ec49affa972f727406
@bertmaher bertmaher requested a review from apaszke as a code owner November 23, 2020 04:22
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D25115773

@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Nov 23, 2020
@dr-ci
Copy link

dr-ci bot commented Nov 23, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit a2da3ee (more details on the Dr. CI page):

  • 5/5 failures introduced in this PR

🕵️ 5 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 (1/5)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Nov 23 06:54:28 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Nov 23 06:54:28 At: 
Nov 23 06:54:28   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize 
Nov 23 06:54:28   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize 
Nov 23 06:54:28  
Nov 23 06:54:28 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Nov 23 06:54:28  
Nov 23 06:54:28 At: 
Nov 23 06:54:28   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize 
Nov 23 06:54:28   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize 
Nov 23 06:54:28  
Nov 23 06:54:28 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Nov 23 06:54:28  
Nov 23 06:54:28 At: 
Nov 23 06:54:28   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize 
Nov 23 06:54:28   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize 
Nov 23 06:54:28  
Nov 23 06:54:28 [W tensorpipe_agent.cpp:504] RPC agent for worker3 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown) 
Nov 23 06:54:28 [W tensorpipe_agent.cpp:504] RPC agent for worker0 encountered error when reading incoming request from worker3: EOF: end of file (this is expected to happen during shutdown) 
Nov 23 06:54:28 [W tensorpipe_agent.cpp:504] RPC agent for worker1 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown) 
Nov 23 06:54:28 [W tensorpipe_agent.cpp:504] RPC agent for worker2 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown) 
Nov 23 06:54:28 ok (1.327s)

See CircleCI build pytorch_linux_bionic_py3_8_gcc9_coverage_test2 (2/5)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Nov 23 06:24:49 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Nov 23 06:24:49 At: 
Nov 23 06:24:49   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(120): serialize 
Nov 23 06:24:49   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(172): serialize 
Nov 23 06:24:49  
Nov 23 06:24:49 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Nov 23 06:24:49  
Nov 23 06:24:49 At: 
Nov 23 06:24:49   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(120): serialize 
Nov 23 06:24:49   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(172): serialize 
Nov 23 06:24:49  
Nov 23 06:24:49 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Nov 23 06:24:49  
Nov 23 06:24:49 At: 
Nov 23 06:24:49   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(120): serialize 
Nov 23 06:24:49   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(172): serialize 
Nov 23 06:24:49  
Nov 23 06:24:49 [W tensorpipe_agent.cpp:504] RPC agent for worker0 encountered error when reading incoming request from worker2: EOF: end of file (this is expected to happen during shutdown) 
Nov 23 06:24:49 [W tensorpipe_agent.cpp:504] RPC agent for worker3 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown) 
Nov 23 06:24:50 ok (2.650s) 
Nov 23 06:24:52   test_return_future_remote (__main__.TensorPipeRpcTestWithSpawn) ... [W tensorpipe_agent.cpp:504] RPC agent for worker2 encountered error when reading incoming request from worker1: EOF: end of file (this is expected to happen during shutdown) 
Nov 23 06:24:52 [W tensorpipe_agent.cpp:504] RPC agent for worker2 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown)

See CircleCI build pytorch_linux_bionic_py3_6_clang9_test (3/5)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Nov 23 06:30:28 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Nov 23 06:30:28 At: 
Nov 23 06:30:28   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize 
Nov 23 06:30:28   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize 
Nov 23 06:30:28  
Nov 23 06:30:28 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Nov 23 06:30:28  
Nov 23 06:30:28 At: 
Nov 23 06:30:28   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize 
Nov 23 06:30:28   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize 
Nov 23 06:30:28  
Nov 23 06:30:28 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Nov 23 06:30:28  
Nov 23 06:30:28 At: 
Nov 23 06:30:28   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize 
Nov 23 06:30:28   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize 
Nov 23 06:30:28  
Nov 23 06:30:28 [W tensorpipe_agent.cpp:504] RPC agent for worker2 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown) 
Nov 23 06:30:28 [W tensorpipe_agent.cpp:504] RPC agent for worker0 encountered error when reading incoming request from worker1: EOF: end of file (this is expected to happen during shutdown) 
Nov 23 06:30:28 [W tensorpipe_agent.cpp:504] RPC agent for worker0 encountered error when reading incoming request from worker2: EOF: end of file (this is expected to happen during shutdown) 
Nov 23 06:30:28 ok (1.840s) 
Nov 23 06:30:29   test_return_future_remote (__main__.TensorPipeRpcTestWithSpawn) ... [W tensorpipe_agent.cpp:504] RPC agent for worker1 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown)

See CircleCI build pytorch_linux_xenial_py3_clang5_asan_test2 (4/5)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Nov 23 05:06:10 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:15:3 in 
Nov 23 05:06:10     #7 0x5584de60170b in PyEval_EvalCode /tmp/build/80754af9/python_1599604603603/work/Python/ceval.c:731 
Nov 23 05:06:10     #8 0x5584de681573 in run_mod /tmp/build/80754af9/python_1599604603603/work/Python/pythonrun.c:1025 
Nov 23 05:06:10     #9 0x5584de68160c in PyRun_StringFlags /tmp/build/80754af9/python_1599604603603/work/Python/pythonrun.c:949 
Nov 23 05:06:10     #10 0x5584de68166e in PyRun_SimpleStringFlags /tmp/build/80754af9/python_1599604603603/work/Python/pythonrun.c:445 
Nov 23 05:06:10     #11 0x5584de685472 in run_command /tmp/build/80754af9/python_1599604603603/work/Modules/main.c:301 
Nov 23 05:06:10     #12 0x5584de685472 in Py_Main /tmp/build/80754af9/python_1599604603603/work/Modules/main.c:749 
Nov 23 05:06:10     #13 0x5584de54f43d in main /tmp/build/80754af9/python_1599604603603/work/Programs/python.c:69 
Nov 23 05:06:10     #14 0x7f398469d83f in __libc_start_main /build/glibc-e6zv40/glibc-2.23/csu/../csu/libc-start.c:291 
Nov 23 05:06:10     #15 0x5584de62ed0a in _start /home/rdonnelly/mc/conda-bld/compilers_linux-64_1534865402226/work/.build/src/glibc-2.12.2/csu/../sysdeps/x86_64/elf/start.S:103 
Nov 23 05:06:10  
Nov 23 05:06:10 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:15:3 in  
Nov 23 05:06:10 + retcode=1 
Nov 23 05:06:10 + set -e 
Nov 23 05:06:10 + return 1 
Nov 23 05:06:10 + [[ pytorch-linux-xenial-py3-clang5-asan-test2 == *-NO_AVX-* ]] 
Nov 23 05:06:10 + [[ pytorch-linux-xenial-py3-clang5-asan-test2 == *-NO_AVX2-* ]] 
Nov 23 05:06:10 + '[' -n https://github.com/pytorch/pytorch/pull/48384 ']' 
Nov 23 05:06:10 + [[ pytorch-linux-xenial-py3-clang5-asan-test2 != *coverage* ]] 
Nov 23 05:06:10 ++ mktemp 
Nov 23 05:06:10 + DETERMINE_FROM=/tmp/tmp.SSEy3OkdrY 
Nov 23 05:06:10 + file_diff_from_base /tmp/tmp.SSEy3OkdrY

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (5/5)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Nov 23 06:24:24 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Nov 23 06:24:24 At: 
Nov 23 06:24:24   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize 
Nov 23 06:24:24   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize 
Nov 23 06:24:24  
Nov 23 06:24:24 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Nov 23 06:24:24  
Nov 23 06:24:24 At: 
Nov 23 06:24:24   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize 
Nov 23 06:24:24   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize 
Nov 23 06:24:24  
Nov 23 06:24:24 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Nov 23 06:24:24  
Nov 23 06:24:24 At: 
Nov 23 06:24:24   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize 
Nov 23 06:24:24   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize 
Nov 23 06:24:24  
Nov 23 06:24:24 [W tensorpipe_agent.cpp:504] RPC agent for worker1 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown) 
Nov 23 06:24:24 [W tensorpipe_agent.cpp:504] RPC agent for worker2 encountered error when reading incoming request from worker1: EOF: end of file (this is expected to happen during shutdown) 
Nov 23 06:24:24 [W tensorpipe_agent.cpp:504] RPC agent for worker0 encountered error when reading incoming request from worker3: EOF: end of file (this is expected to happen during shutdown) 
Nov 23 06:24:24 ok (1.635s) 
Nov 23 06:24:25   test_return_future_remote (__main__.TensorPipeRpcTestWithSpawn) ... [W tensorpipe_agent.cpp:504] RPC agent for worker0 encountered error when reading incoming request from worker3: EOF: end of file (this is expected to happen during shutdown)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 4 times.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in adb4fd3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apaszke apaszke Awaiting requested review from apaszke

Assignees
No one assigned
Labels
cla signed fb-exported Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bertmaher @facebook-github-bot